This repository has been archived by the owner on Mar 7, 2021. It is now read-only.
Unpin bindgen and use --size_t-is-usize
#235
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alex
reviewed
Aug 9, 2020
Cargo.toml
Outdated
| @@ -8,6 +8,6 @@ edition = "2018" | |||
| bitflags = "1" | |||
|
|
|||
| [build-dependencies] | |||
| bindgen = "0.51.0" | |||
| bindgen = "*" | |||
There was a problem hiding this comment.
I don't think we should be unpinning. I think we should bump the pin and maybe add depndabot.
Add an assertion that doing so is safe. See rust-lang/rust-bindgen#1671 Can't use static_assert from <linux/build_bug.h> because that's 5.1+-only, but the underlying _Static_assert compiler builtin is available widely. See torvalds/linux@6bab69c
alex
approved these changes
Aug 9, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add an assertion that doing so is safe.
See rust-lang/rust-bindgen#1671
Can't use static_assert from <linux/build_bug.h> because that's
5.1+-only, but the underlying _Static_assert compiler builtin is
available widely.
See torvalds/linux@6bab69c