Skip to content
This repository has been archived by the owner on Mar 7, 2021. It is now read-only.

Build fails on v5.2+ #124

Closed
geofft opened this issue Aug 18, 2019 · 0 comments
Closed

Build fails on v5.2+ #124

geofft opened this issue Aug 18, 2019 · 0 comments

Comments

@geofft
Copy link
Collaborator

geofft commented Aug 18, 2019

Since torvalds/linux@cdd750b, the __c_flags variable used by kernel-cflags-helper is gone, and we should just use _c_flags. Probably the right thing to do is use __c_flags if it exists and fall back to _c_flags, for correctness with older kernels. (You can also do version comparisons with like, $(shell expr) or something but that sounds like a pain.)

Maybe it's worth seeing if there's a cleaner way of doing all this.

Originally reported in lizhuohua/linux-kernel-module-rust#1.

geofft added a commit that referenced this issue Aug 18, 2019
torvalds/linux@cdd750bf gets rid of __c_flags, so just use _c_flags if
__c_flags is unset.
geofft added a commit that referenced this issue Aug 18, 2019
torvalds/linux@cdd750bf gets rid of __c_flags, so just use _c_flags if
__c_flags is unset.
geofft added a commit that referenced this issue Aug 18, 2019
torvalds/linux@cdd750bf gets rid of __c_flags, so just use _c_flags if
__c_flags is unset.
@geofft geofft closed this as completed in f7f8551 Aug 18, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant