Skip to content
This repository has been archived by the owner on Sep 2, 2021. It is now read-only.

Enable Binding of DisplayName of Link and LinkGroup for i18n purposes #129

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

prskr
Copy link

@prskr prskr commented Jul 26, 2016

Added DependencyObject class to inheritance hierarchy of Displayable to be able to register DependencyProperties in Link and LinkGroup to enable binding of the DisplayName of both for internationalization.

…ster DisplayName and Source of Link and LinkGroup as DependencyProperties to be able to bind them for i18n purposes
@Dvornik
Copy link

Dvornik commented Jul 31, 2016

Thank you! It's really what I need.

@gabriel-alecu
Copy link

Is MUI still being developed? I need this PR.

@prskr
Copy link
Author

prskr commented Dec 23, 2016

I don't know. I thought it would be nice to be able to bind these properties for i18n and other purposes but I never had contact to the maintainer. Perhaps she or he simply doesn't want it or hasn't had time to merge it.

I even forgot that this pull request exists...

@shyakocat
Copy link

shyakocat commented Jan 13, 2020

I have a question.

If I use DisplayName="{DynamicResource ...}" and then change the ResourceDictionary, DisplayName won't change while other property (like Text="{DynamicResource ...}" of TextBlock) will change.

Besides, If I change ResourceDictionary in constructor of MainWindow, DisplayName changes. But after that DisplayName never changes.

How to solve that?

Also, DisplayName shows nothing when I use {Binding ...}. I don't know what's wrong with my code.

@prskr
Copy link
Author

prskr commented Jan 17, 2020

@shyakocat your problem is totally related to this PR.

WPF requires every property that should be binded to be a DependencyProperty. Because the DisplayName of the Displayable class is not a DependencyProperty it is not possible to dynamically update this property via INotifyPropertyChanged mechanism.
So neither DynamicRessource nor Binding will work unless you fork this project an implement it on your own 😉

@shyakocat
Copy link

Thank you very much.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants