Raising lelantus joinsplit limit to 5000 #951
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The idea behind this is a balance of allowing adoption of Lelantus tx to happen especially as we move to a privacy by default model while balancing with mitigating risk of a new privacy protocol. It is intended for this limit to be raised as we grow more confident on the protocol. Related to this is #947 which allows the core team to turn off Lelantus in case of an attack but with a limited validity period of one year as we allow the protocol to mature. |
levonpetrosyan93
previously approved these changes
Dec 25, 2020
psolstice
force-pushed
the
lelantus-5k-limit
branch
from
0d44afd to
d0325a7
Compare
a-bezrukov
approved these changes
Dec 25, 2020
|
This pull request fixes 2 alerts when merging d0325a7 into 75f72d0 - view on LGTM.com fixed alerts:
|
levonpetrosyan93
approved these changes
Dec 25, 2020
Closed
|
@reubenyap can we increase the limit on transparent funds to at least 50k FIRO, the rationale is here |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
Raise lelantus limits to 5001 per transaction and 5100 per block. Sporks (#947 ) can be used to lower this limit temporarily.
Code changes brief
Change of several constants