Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix issue with parsing legacy HD keypath #536

Merged
merged 4 commits into from
Jul 26, 2019
Merged

Fix issue with parsing legacy HD keypath #536

merged 4 commits into from
Jul 26, 2019

Conversation

riordant
Copy link
Contributor

@riordant riordant commented Jul 23, 2019 •
edited
Loading

Fixes issue where old keypath format does not parse correctly in importwallet. Also adds information on hardened components to CKeyMetadata

@riordant riordant added this to the v0.13.8.3 milestone Jul 23, 2019
@reubenyap reubenyap added the bug label Jul 24, 2019
thebevrishot
thebevrishot reviewed Jul 24, 2019
View reviewed changes
src/wallet/walletdb.h Outdated Show resolved Hide resolved
@riordant riordant changed the title Fix issue with parsing legacy hd keypath Fix issue with parsing legacy HD keypath Jul 25, 2019
thebevrishot
thebevrishot reviewed Jul 25, 2019
View reviewed changes
Copy link
Contributor

@thebevrishot thebevrishot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating. Have some type issue.

src/wallet/walletdb.h Outdated Show resolved Hide resolved
levonpetrosyan93
levonpetrosyan93 previously approved these changes Jul 25, 2019
View reviewed changes
Copy link
Contributor

@levonpetrosyan93 levonpetrosyan93 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thebevrishot
thebevrishot reviewed Jul 26, 2019
View reviewed changes
src/wallet/walletdb.h Outdated Show resolved Hide resolved
src/wallet/walletdb.h Outdated Show resolved Hide resolved
thebevrishot
thebevrishot approved these changes Jul 26, 2019
View reviewed changes
Copy link
Contributor

@thebevrishot thebevrishot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for fixing. LGTM

@thebevrishot thebevrishot merged commit b4fcbfb into master Jul 26, 2019
@thebevrishot thebevrishot deleted the keypath-fix branch July 26, 2019 06:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

@thebevrishot thebevrishot thebevrishot approved these changes

@a-bezrukov a-bezrukov Awaiting requested review from a-bezrukov

@ultimaweapon ultimaweapon Awaiting requested review from ultimaweapon

Assignees
No one assigned
Labels
bug high priority
Projects
None yet
Milestone
v0.13.8.3
Development

Successfully merging this pull request may close these issues.
4 participants
@riordant @thebevrishot @levonpetrosyan93 @reubenyap