-
-
Notifications
You must be signed in to change notification settings - Fork 353
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Macos git action build fix #1435
Conversation
WalkthroughThe recent modifications streamline the installation and configuration process in the CI workflow for a project. Key updates include the addition of Changes
Poem
Recent Review DetailsConfiguration used: CodeRabbit UI Files selected for processing (1)
Files skipped from review as they are similar to previous changes (1)
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
2d55f78
to
faac9c7
Compare
@@ -181,7 +181,7 @@ jobs: | |||
working-directory: ${{ env.SOURCE_ARTIFACT }} | |||
- name: Build Firo | |||
run: | | |||
./configure --disable-jni --prefix=$(grealpath depends/x86_64-apple-darwin*) | |||
./configure --prefix=`pwd`/depends/`depends/config.guess` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please make sure it's used on mac only. This option can wreak havoc if used when cross-compiling
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@psolstice Тhis configuration is used only for Mac, for the rest there are separate config. Thank you)
Summary by CodeRabbit