Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixes for exchange address implementation #1375

Merged
merged 3 commits into from
Dec 17, 2023
Merged

Conversation

psolstice
Copy link
Contributor

PR intention

This PR solves the following issues:

  • outputs of transactions sending funds to exchange addresses are treated as change
  • listtransactions doesn't output exchange address txes
  • gettransaction can't parse exchange address
  • coin control dialog shows exchange addresses in incorrect group
  • incorrect prefix for testnet's exchange address

Code changes brief

getnewexchangeaddress now properly adds generated address to the wallet's address book

@reubenyap reubenyap merged commit 9a2377c into master Dec 17, 2023
6 checks passed
@reubenyap reubenyap deleted the exchange-address-fix branch December 17, 2023 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants