Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Zero value mints #1173

Merged
merged 3 commits into from
Jul 20, 2022
Merged

Zero value mints #1173

merged 3 commits into from
Jul 20, 2022

Conversation

levonpetrosyan93
Copy link
Contributor

Fixes #1164

Code changes

  • 0 value mints are being created in joinsplit transaction, when there is no change, listlelantusmints rpc now skips such mints, until you pass true during rpc call, to show all mints.
  • In some cases jmints were being shown in transaction list after restoration, as wallet did not recognize such mints as changes, now it skips the output in case it is jmint.

@lgtm-com
Copy link

lgtm-com bot commented May 8, 2022

This pull request fixes 3 alerts when merging fd61e32 into 4ac8771 - view on LGTM.com

fixed alerts:

  • 3 for Unused static function

@lgtm-com
Copy link

lgtm-com bot commented May 24, 2022

This pull request fixes 2 alerts when merging f5921af into 4ac8771 - view on LGTM.com

fixed alerts:

  • 2 for Unused static function

@reubenyap reubenyap merged commit 1bd003c into master Jul 20, 2022
@reubenyap reubenyap deleted the zero_value_mints branch July 20, 2022 13:32
levonpetrosyan93 added a commit that referenced this pull request May 17, 2023
* Show 0 value mints on listlelantusmints rpc output only if you pass true, to show all mints

* Don't show jmints in transaction list after restoration

* Empty commit
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lelantus mint creates zero value transactions
3 participants