Fix for ProRegTx transaction conflict #1124
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
levonpetrosyan93
approved these changes
Jan 12, 2022
AaronFeickert
pushed a commit
to AaronFeickert/firo
that referenced
this pull request
Jan 25, 2022
* Don't allow collateral spend in same block as proreg tx * Fix to MN check condition * Don't let miner include ProRegTx and transaction spending collateral into one block * Version bump
levonpetrosyan93
pushed a commit
that referenced
this pull request
May 17, 2023
* Don't allow collateral spend in same block as proreg tx * Fix to MN check condition * Don't let miner include ProRegTx and transaction spending collateral into one block * Version bump
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR intention
In rare circumstances node may behave incorrectly when certain types of transaction are in the same block
Code changes brief
Reject blocks with a conflict of
ProRegTxtransaction having a collateral in itsvout(one produced byprotx register_fund)When mining don't allow conflicting transactions into the same block