Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improved batch verification for legacy one-of-many proofs #1038

Merged
merged 4 commits into from
Mar 2, 2022
Merged

Improved batch verification for legacy one-of-many proofs #1038

merged 4 commits into from
Mar 2, 2022
+292 −273

Conversation

AaronFeickert
Copy link
Contributor

Improves batch verification for legacy one-of-many proofs by reducing to a single multiscalar multiplication operation. Adds additional sanity checks for the verifier routine. Removes redundant code while retaining backwards compatibility.

Review requested.

@lgtm-com
Copy link

lgtm-com bot commented May 28, 2021

This pull request fixes 5 alerts when merging 9cd2998 into 677b54c - view on LGTM.com

fixed alerts:

  • 5 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 9cd2998 to fcb8db9 Compare June 2, 2021 20:15
@lgtm-com
Copy link

lgtm-com bot commented Jun 2, 2021

This pull request fixes 8 alerts when merging fcb8db9 into 677b54c - view on LGTM.com

fixed alerts:

  • 5 for Multiplication result converted to larger type
  • 3 for Unused static function

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from fcb8db9 to a256f64 Compare June 2, 2021 23:21
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2021

This pull request fixes 9 alerts when merging b388d67 into 677b54c - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert marked this pull request as ready for review June 3, 2021 13:58
@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from b388d67 to 3f17fce Compare June 3, 2021 13:59
@lgtm-com
Copy link

lgtm-com bot commented Jun 3, 2021

This pull request fixes 9 alerts when merging 3f17fce into 677b54c - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 3f17fce to 146ad76 Compare June 9, 2021 15:29
@lgtm-com
Copy link

lgtm-com bot commented Jun 9, 2021

This pull request fixes 9 alerts when merging 146ad76 into e2c8db6 - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@reubenyap reubenyap added this to the v0.14.7.1 milestone Jun 22, 2021
@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 146ad76 to b9f0670 Compare June 24, 2021 14:10
@lgtm-com
Copy link

lgtm-com bot commented Jun 24, 2021

This pull request fixes 9 alerts when merging b9f0670 into 892c64e - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch 2 times, most recently from 4a2e4c3 to b243fd4 Compare June 28, 2021 15:16
@lgtm-com
Copy link

lgtm-com bot commented Jun 28, 2021

This pull request fixes 9 alerts when merging b243fd4 into bc92fc9 - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from b243fd4 to 741138f Compare July 6, 2021 17:36
@lgtm-com
Copy link

lgtm-com bot commented Jul 6, 2021

This pull request fixes 10 alerts when merging 741138f into e3f929c - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type
  • 1 for Unused static function

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 741138f to d3ade5c Compare July 8, 2021 03:14
@lgtm-com
Copy link

lgtm-com bot commented Jul 8, 2021

This pull request fixes 9 alerts when merging d3ade5c into ed2bd7e - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from d3ade5c to e3c18a8 Compare July 9, 2021 19:31
@lgtm-com
Copy link

lgtm-com bot commented Jul 9, 2021

This pull request fixes 9 alerts when merging e3c18a8 into 99ee21d - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from e3c18a8 to ba0a478 Compare July 12, 2021 17:59
@lgtm-com
Copy link

lgtm-com bot commented Jul 12, 2021

This pull request introduces 2 alerts and fixes 9 when merging ba0a478 into 8192c5f - view on LGTM.com

new alerts:

  • 2 for Unused static function

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from ba0a478 to 8c61ff0 Compare July 15, 2021 15:25
@reubenyap reubenyap modified the milestones: v0.14.7.1, v0.14.8.1 ProgPOW Jul 15, 2021
@lgtm-com
Copy link

lgtm-com bot commented Jul 15, 2021

This pull request introduces 2 alerts and fixes 9 when merging 75f9c96 into c4918fd - view on LGTM.com

new alerts:

  • 2 for Unused static function

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch 2 times, most recently from c7fb7a5 to 2208c86 Compare August 17, 2021 18:08
@lgtm-com
Copy link

lgtm-com bot commented Aug 17, 2021

This pull request fixes 9 alerts when merging 2208c86 into b2eba12 - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@levonpetrosyan93
Copy link
Contributor

LGTM, smoke test done successfully.

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 2208c86 to 021635b Compare September 7, 2021 18:16
@lgtm-com
Copy link

lgtm-com bot commented Sep 7, 2021

This pull request fixes 9 alerts when merging 021635b into 460c17f - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@levonpetrosyan93
Copy link
Contributor

Here are the performance numbers on my machine
N = 16384 n = 4 m = 7 M = 1
Verify time New 232 ms
Verify time Old 233 ms
N = 16384 n = 4 m = 7 M = 5
Verify time New 245 ms
Verify time Old 251 ms
N = 16384 n = 4 m = 7 M = 10
Verify time New 273 ms
Verify time Old 287 ms
N = 16384 n = 4 m = 7 M = 50
Verify time New 397 ms
Verify time Old 473 ms
N = 16384 n = 4 m = 7 M = 100
Verify time New 534 ms
Verify time Old 621 ms
N = 16384 n = 4 m = 7 M = 500
Verify time New 1812 ms
Verify time Old 2173 ms
N = 16384 n = 4 m = 7 M = 1000
Verify time New 3535 ms
Verify time Old 4267 ms

@lgtm-com
Copy link

lgtm-com bot commented Sep 20, 2021

This pull request fixes 9 alerts when merging f909d94 into 460c17f - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@reubenyap reubenyap modified the milestones: v0.14.9.0 FiroPoW, v0.14.9.1 Maintenance Release Sep 26, 2021
@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from f909d94 to 898823b Compare December 19, 2021 19:33
@lgtm-com
Copy link

lgtm-com bot commented Dec 20, 2021

This pull request fixes 9 alerts when merging 898823b into 738308b - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 898823b to 4e61302 Compare February 17, 2022 20:51
@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 4e61302 to 8eff941 Compare February 17, 2022 23:17
@AaronFeickert AaronFeickert force-pushed the sigma-verifier-batching branch from 8eff941 to c1e4c8e Compare February 19, 2022 14:37
@lgtm-com
Copy link

lgtm-com bot commented Feb 19, 2022

This pull request fixes 9 alerts when merging c1e4c8e into d73a892 - view on LGTM.com

fixed alerts:

  • 9 for Multiplication result converted to larger type

@reubenyap reubenyap merged commit a8474eb into firoorg:master Mar 2, 2022
@AaronFeickert AaronFeickert deleted the sigma-verifier-batching branch March 2, 2022 17:05
levonpetrosyan93 pushed a commit that referenced this pull request May 17, 2023
@AaronFeickert @levonpetrosyan93
Improved batch verification for legacy one-of-many proofs (#1038)
5db0f13 
* Sigma verifier batching

* Namespace fixes

* Simplify types

* Remove unnecessary function declaration
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@levonpetrosyan93 levonpetrosyan93 levonpetrosyan93 approved these changes

@psolstice psolstice Awaiting requested review from psolstice

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@AaronFeickert @levonpetrosyan93 @reubenyap