Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added extra analogRead() to let ADC cool off #340

Closed
wants to merge 1 commit into from
Closed

Added extra analogRead() to let ADC cool off #340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions examples/StandardFirmata/StandardFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -805,6 +805,8 @@ void loop()
if (IS_PIN_ANALOG(pin) && Firmata.getPinMode(pin) == PIN_MODE_ANALOG) {
analogPin = PIN_TO_ANALOG(pin);
if (analogInputsToReport & (1 << analogPin)) {
// Extra analogRead() to cover ADC cooling-off period for higher accuracy
analogRead(analogPin);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a waste of cycles if a user only has one analog input. However you could add a counter that increments each time you enter this block and then only if that count > 0 perform the extra analogRead:

if (analogReadCounter++ > 0) {
  analogRead(analogPin);
}

and reset analogReadCounter to 0 before the for loop.

Firmata.sendAnalog(analogPin, analogRead(analogPin));
}
}
Expand Down