Standalone #31
Merged
Standalone #31
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
February 15, 2019 19:41
either guestmount or fuse-ext2.
left-over sudo's that were sneaking around.
accident on earlier versions of buildroot, now we do it explicitly. Conflicts: wlutil/wlutil.py
|
BTW: This PR addresses #20 |
added 7 commits
June 7, 2019 17:33
on a fresh clone (it would timeout on the first test otherwise due to buildroot).
davidbiancolin
approved these changes
Jun 25, 2019
| @@ -6,9 +6,6 @@ import logging | |||
| import wlutil | |||
| import contextlib | |||
|
|
|||
| if 'RISCV' not in os.environ: | |||
There was a problem hiding this comment.
You don't depend on this variable anymore?
There was a problem hiding this comment.
We never depended on it explicitly. I was just using it as a proxy to detect if you'd sourced sourcme. In reality, we just depend on the riscv toolchain. I just added back a check for that instead.
…ource sourceme.sh
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previous versions of firemarshal required sudo to operate. This wasn't intrinsic, just convenient. It also had some artificial dependencies on being a submodule of firesim. This PR removes these requirements so that firesim-software can work on its own.
The firesim submodule was a minor change that doesn't affect behavior significantly (just changes some warnings).
Getting rid of sudo was more involved. I had to switch to guestmount (a FUSE tool). Implications/changes: