Randomly choose from all available IP addresses #220
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is to avoid getting stuck on the same IP which doesn't work for whatever reason. pool.supportxmr.com uses DNS for load balancing, and it had issues with xmr-stak miners when one of the servers went down and all xmr-stak miners that were on that server didn't switch to the other working server. This change fixes the bug.
|
Thanks! xref to previous - pr #219 |
psychocrypt
requested changes
Jul 17, 2017
| pSockAddr = ipv6; | ||
| else if (ipv4 != nullptr && ipv6 != nullptr) | ||
| else if (!ipv4.empty() && ipv6.empty()) | ||
| pSockAddr = ipv4[rand() % ipv4.size()]; |
There was a problem hiding this comment.
rand() must be initialized with std::srand(std::time(0)); else the random numbers are always the some after the start. documentation rand
xmrig
added a commit
to xmrig/xmrig
that referenced
this pull request
Jul 17, 2017
|
Sigh, we broke the mac build. This needs to be fixed before merging. |
|
Fixed it. Stupid Apple not respecting C++ standard... |
|
Looking good now. @psychocrypt I verified that rand() is correctly seeded now (at least on gcc, don't expect any additional trouble on msvc). Thanks @SChernykh ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is to avoid getting stuck on the same IP which doesn't work for whatever reason.
pool.supportxmr.com uses DNS for load balancing, and it had issues with xmr-stak miners when one of the servers went down and all xmr-stak miners that were on that server didn't switch to the other working server. This change fixes the bug.