WIP: Event based refactor #17
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This reverts commit 61ce1e5. Without JSON.stringify, the variables being replaced ends up as a number type or a variable rather than a string type value.
Alos cleanup some of the decaffeinate stuff
WebSocketTransport is upgraded and working with a basic manual test, needs automated tests LongPollTransport is mostly upgraded and needs testing
|
@adam-h looking goooood. |
Lets you use chrome://inspect with node8
nguyenj
force-pushed
the
webpackv3
branch
3 times, most recently
from
4601a4e to
040df7b
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #11
This is a WIP of an event based interface to Firehose, replacing the current callback interface completely.
@nguyenj What do you think about this?
TODO:
multiplexoption toConnection(rather than having aMultiplexedConnection