Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

retry mage-test-stand setup if it fails #284

Merged
merged 2 commits into from
Nov 24, 2015

Conversation

tkn98
Copy link
Contributor

@tkn98 tkn98 commented Nov 4, 2015

@tkn98 tkn98 force-pushed the patch-1 branch 3 times, most recently from 395b226 to f625f94 Compare November 9, 2015 07:13
@ktomk
Copy link
Contributor

ktomk commented Nov 9, 2015

We fixed the underlying issue upstream in magerun and it is already part of mage test stand (AOEpeople/MageTestStand@f2038ef). These updates becamse important for working magento downloads. They are technically not that important for the retry-issue this PR was originally about. Just saying.

@sprankhub
Copy link
Member

Thanks! Any idea why it fails during the cleanup? It fails during the following command:

rm -rf /tmp/mageteststand.25JSVJ94

But it also seems that he cleans up too early. It does not finish the test FireGento_Pdf_Test_Model_CreditmemoTest::itShouldReturnAZendPdf, but cleans up before. It does not show any error though, which is strange...?

@sprankhub
Copy link
Member

Idea: Older versions probably fail because Magento < 1.9 does not natively support PHP 5.4 / 5.5...

@tkn98
Copy link
Contributor Author

tkn98 commented Nov 9, 2015

I don't understand why the exit status differs between the builds. perhaps the download doesn't work. because curl is silenced this is not visible. I will try the one or other thing to make things more visible.

@Schrank
Copy link
Member

Schrank commented Nov 9, 2015

@tkn98 You are great, thanks for your help!

@tkn98
Copy link
Contributor Author

tkn98 commented Nov 9, 2015

From my end this now looks like a failing test to me: FireGento_Pdf_Test_Model_CreditmemoTest::itShouldReturnAZendPdf

This test is failing hard, that means with either a non catchable fatal error (hinted by exit status 255) or even some other hard failure that the php binary crashed. I don't have a good reference at hand that explains all PHP exit codes, I know that 255 is an error.

I can't say whether or not -d display_errors=1 does actually work as intended in that case. I'd say it normally should work. That then again would be a hint that it's not an error but just a crash.

Both these statements are speculative. So they are of no concrete help and don't take them for real.

Maybe if you look into the test you can find out what is going on.

sprankhub added a commit that referenced this pull request Nov 24, 2015
[~BUGFIX] retry mage-test-stand setup if it fails
@sprankhub sprankhub merged commit 691e4b8 into firegento:development Nov 24, 2015
@tkn98
Copy link
Contributor Author

tkn98 commented Nov 24, 2015

@sprankhub The file build/travis/mageteststand-setup.sh is not used any longer and can be removed. It's just a forgotten leftover from testing the build.

@sprankhub
Copy link
Member

@tkn98 00dde26 ;) Thanks!

By the way, this is a good explanation of PHP error code 255. I still try to fix the error. I encountered a bug (ccf839d), but it does not seem to be the issue.

@tkn98 tkn98 deleted the patch-1 branch November 24, 2015 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants