This repository has been archived by the owner on May 2, 2018. It is now read-only.
Configure window reps title #73
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @nchevobbe |
Sure, doesn't prevent us from discussing though :) |
juliandescottes
force-pushed
the
window-title
branch
from
6ae4fd8 to
ec69508
Compare
nchevobbe
approved these changes
Feb 11, 2017
juliandescottes
force-pushed
the
window-title
branch
from
ec69508 to
83ea3e6
Compare
|
Thanks for the feedback @nchevobbe ! |
|
(actually I'll wait for you to merge your big PR, and I'll rebase on top of it) |
|
it's merged now :) |
nchevobbe
approved these changes
Feb 11, 2017
juliandescottes
force-pushed
the
window-title
branch
from
0e370a5 to
69384d8
Compare
juliandescottes
force-pushed
the
window-title
branch
from
69384d8 to
06f354c
Compare
|
I added some simple tests in the existing test file for grip, grip-array and grip-map. I also added support for custom titles for grip array and grip maps, otherwise the tests were a little weird (we were defining a custom title that wasn't visible anywhere in the output) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempt at fixing #47
Instead of introducing the debugger.html specific isGlobal check, I wanted to reuse the "title" property already used in a few reps.
This made me realise that we had a bug with grip and grip-array reps which were copying their title prop to their children. The first commit fixes that (as well as updating a test that relied on the bug).
The second commit adds the title prop to the window rep, as well as a TINY render mode. This means that now window objects will be rendered as Window (or their customized title) when they are rendered in TINY mode.
Comparing with the old console, this is a behaviour change, as the old console always displayed
Window -> urlit seems. I think this is an acceptable change though (and Chrome only displaysWindowfor instance).I'll wait for your feedback before adding tests dedicated to that.