Skip to content
This repository has been archived by the owner on May 2, 2018. It is now read-only.

Run mochitests #45

Merged
merged 11 commits into from
Jan 21, 2017
Merged

Conversation

juliandescottes
Copy link
Member

@juliandescottes juliandescottes commented Jan 17, 2017

I thought we updated the exports necessary for mc, but looks like I was wrong.

Also I don't think we use the root index.js so I deleted it.

cc @jasonLaster

@juliandescottes juliandescottes changed the title Bundle exports Run mochitests Jan 17, 2017
@juliandescottes
Copy link
Member Author

This work needs to wait for https://bugzilla.mozilla.org/show_bug.cgi?id=1325401 to land

@@ -1,9 +0,0 @@
const Rep = require("./src/reps/rep").Rep;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔫

* License, v. 2.0. If a copy of the MPL was not distributed with this file,
* You can obtain one at http://mozilla.org/MPL/2.0/. */

"use strict";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jasonLaster
Copy link
Contributor

We'll likely want to update the MC docker image soon so that we pull in the reps changes which will be important for this to work

@juliandescottes
Copy link
Member Author

https://bugzilla.mozilla.org/show_bug.cgi?id=1325401 just landed in central.

I just resynchronized all reps with what we have in MC too.

@juliandescottes
Copy link
Member Author

This is almost ready to land, but we first have to merge firefox-devtools/devtools-core#90, release a new version of launchpad, and use it here.

@jasonLaster
Copy link
Contributor

I'll review soon and then we can land.

The docker image should be easy to update

@jasonLaster jasonLaster merged commit ff762ea into firefox-devtools:master Jan 21, 2017
@jasonLaster
Copy link
Contributor

I squashed the commits into one so that it would be easier to take out if there is something we need to change.

I hope to have time to setup the docker image this weekend so we can try running the mochitests on circle monday.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants