-
Notifications
You must be signed in to change notification settings - Fork 13
Run mochitests #45
Run mochitests #45
Conversation
This work needs to wait for https://bugzilla.mozilla.org/show_bug.cgi?id=1325401 to land |
@@ -1,9 +0,0 @@ | |||
const Rep = require("./src/reps/rep").Rep; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🔫
* License, v. 2.0. If a copy of the MPL was not distributed with this file, | ||
* You can obtain one at http://mozilla.org/MPL/2.0/. */ | ||
|
||
"use strict"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
We'll likely want to update the MC docker image soon so that we pull in the reps changes which will be important for this to work |
cb7b641
to
55916c9
Compare
https://bugzilla.mozilla.org/show_bug.cgi?id=1325401 just landed in central. I just resynchronized all reps with what we have in MC too. |
This is almost ready to land, but we first have to merge firefox-devtools/devtools-core#90, release a new version of launchpad, and use it here. |
4a8cdcb
to
d26e143
Compare
d26e143
to
04edbd8
Compare
I'll review soon and then we can land. The docker image should be easy to update |
I squashed the commits into one so that it would be easier to take out if there is something we need to change. I hope to have time to setup the docker image this weekend so we can try running the mochitests on circle monday. |
I thought we updated the exports necessary for mc, but looks like I was wrong.
Also I don't think we use the root index.js so I deleted it.
cc @jasonLaster