Skip to content
This repository has been archived by the owner on May 2, 2018. It is now read-only.

Commit

Permalink
Merge pull request #70 from juliandescottes/release-0.1.0
Browse files Browse the repository at this point in the history
Release 0.1.0
  • Loading branch information
juliandescottes authored Feb 10, 2017
2 parents 1027702 + b58967c commit c62df46
Show file tree
Hide file tree
Showing 4 changed files with 40 additions and 6 deletions.
30 changes: 30 additions & 0 deletions RELEASE.md
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
How to create a new Reps release for mozilla-central.
Before you get started, you will need clones of devtools-reps and mozilla-central, as well as
a Bugzilla account.

1. Go to your clone of devtools-reps
a. create a release branch on github
b. update minor version in package.json, reset build version:
v0.N.X -> v0.N+1.0
c. create a PR on Github for this release
d. run /bin/publish-assets.js to create the bundle

2. Go to your clone of mozilla-central
a. update mozilla-central to the latest
b. copy :
assets/build/reps.js -> devtools/shared/components/reps
assets/build/reps.css -> devtools/shared/components/reps
assets/build/load-reps.js -> devtools/shared/components/reps
assets/build/mochitest/* -> devtools/shared/components/reps/test/mochitest/
c. commit 'Bug XXXXXXX - reps v0.N+1.0: update devtools reps bundle from GitHub;r=reviewer'
d. push to try, test locally, submit for review etc ...
e. while try fails or some problem is detected, go back to devtools-reps, fix the issue,
create a new bundle and go back to 2.a
f. when everything is fine and the patch is r+, land on autoland or inbound
g. merge the PR on github
h. create a tag on github

After that any issue with the bundle should be addressed with a new build version.
Ideally, if the bundle has to be updated in mozilla-central for a bugfix, a corresponding
tag should be created on GitHub.

2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "devtools-reps",
"version": "0.0.8",
"version": "0.1.0",
"description": "Devtools Reps",
"main": "src/index.js",
"scripts": {
Expand Down
11 changes: 7 additions & 4 deletions src/reps/load-reps.js
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,13 @@ define(function (require, exports, module) {
parseURLEncodedText = bundle.parseURLEncodedText;
parseURLParams = bundle.parseURLParams;
} else {
({ createFactories, parseURLEncodedText, parseURLParams } =
require("devtools/client/shared/components/reps/rep-utils"));
REPS = require("devtools/client/shared/components/reps/rep").REPS;
MODE = require("devtools/client/shared/components/reps/constants").MODE;
// Commenting out all requires, otherwise requirejs will agressively load all
// dependencies when loading load-reps.js, which will fail because files have been
// removed.
// ({ createFactories, parseURLEncodedText, parseURLParams } =
// require("devtools/client/shared/components/reps/rep-utils"));
// REPS = require("devtools/client/shared/components/reps/rep").REPS;
// MODE = require("devtools/client/shared/components/reps/constants").MODE;
}

exports.REPS = REPS;
Expand Down
3 changes: 2 additions & 1 deletion src/test/mochitest/head.js
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,8 @@ function shallowRenderComponent(component, props) {
/**
* Test that a rep renders correctly across different modes.
*/
function testRepRenderModes(modeTests, testName, componentUnderTest, gripStub, props = {}) {
function testRepRenderModes(modeTests, testName, componentUnderTest, gripStub,
props = {}) {
modeTests.forEach(({mode, expectedOutput, message}) => {
const modeString = typeof mode === "undefined" ? "no mode" : mode.toString();
if (!message) {
Expand Down

0 comments on commit c62df46

Please sign in to comment.