Fix errors reported by eslint

.eslintrc.js

@@ -10,7 +10,6 @@ module.exports = {
   ],
   "env": {
     "es6": true,
-    "node": true,
     "browser": true
   },
   "globals": {

package.json

@@ -5,7 +5,7 @@
   "main": "src/index.js",
   "scripts": {
     "start": "node bin/dev-server.js",
-    "lint-js": "eslint src/**/*.js",
+    "lint-js": "eslint src",
     "firefox": "./node_modules/.bin/start-firefox --start --location https://devtools-html.github.io/debugger-examples/",
     "chrome": "./node_modules/.bin/start-chrome",
     "copy-assets": "node bin/copy-assets",

src/index.js

@@ -1,5 +1,3 @@
-const React = require("react");
-
 const { MODE } = require("./reps/constants");
 const { REPS } = require("./reps/rep");
 const {

src/launchpad/actions/expressions.js

@@ -7,7 +7,7 @@ function evaluateInput(input) {
       const packet = await client.clientCommands.evaluate(input, {});
       dispatch(addExpression(input, packet));
     } catch (err) {
-      console.warn("Error when evaluating expression", err)
+      console.warn("Error when evaluating expression", err);
     }
   };
 }

src/launchpad/components/Console.js

@@ -11,23 +11,23 @@ const ResultsList = createFactory(require("./ResultsList"));
 require("./Console.css");
 
 const Console = React.createClass({
+  displayName: "Console",
+
   propTypes: {
     client: PropTypes.object.isRequired,
     shortcuts: PropTypes.object.isRequired,
     clearExpressions: PropTypes.func.isRequired,
   },
 
-  displayName: "Console",
-
-  componentDidMount: function() {
+  componentDidMount: function () {
     this.props.shortcuts.on("CmdOrCtrl+Shift+L", this.props.clearExpressions);
   },
 
-  componentWillUnmount: function() {
+  componentWillUnmount: function () {
     this.props.shortcuts.off("CmdOrCtrl+Shift+L");
   },
 
-  render: function() {
+  render: function () {
     let {
       addInput,
       changeCurrentInput,

src/launchpad/components/Header.js

@@ -7,6 +7,8 @@ require("./Header.css");
 
 const Header = React.createClass({
 
+  displayName: "Header",
+
   propTypes: {
     addInput: PropTypes.func.isRequired,
     changeCurrentInput: PropTypes.func.isRequired,
@@ -16,20 +18,18 @@ const Header = React.createClass({
     navigateInputHistory: PropTypes.func.isRequired,
   },
 
-  displayName: "Header",
-
-  onSubmitForm: function(e) {
+  onSubmitForm: function (e) {
     e.preventDefault();
     let data = new FormData(e.target);
     let expression = data.get("expression");
     this.props.addInput(expression);
   },
 
-  onInputChange: function(e) {
+  onInputChange: function (e) {
     this.props.changeCurrentInput(e.target.value);
   },
 
-  onInputKeyDown: function(e) {
+  onInputKeyDown: function (e) {
     if (["ArrowUp", "ArrowDown"].includes(e.key)) {
       this.props.navigateInputHistory(e.key === "ArrowUp"
         ? constants.DIR_BACKWARD
@@ -38,7 +38,7 @@ const Header = React.createClass({
     }
   },
 
-  onClearButtonClick: function(e) {
+  onClearButtonClick: function (e) {
     this.props.clearResultsList();
   },
 
@@ -50,9 +50,8 @@ const Header = React.createClass({
 
     return dom.header(
       { className: "console-header" },
-      dom.form({
-          onSubmit: this.onSubmitForm,
-        },
+      dom.form(
+        { onSubmit: this.onSubmitForm, },
         dom.h1({}, "Reps"),
         dom.input({
           type: "text",

src/launchpad/components/QuickLinks.js

@@ -5,12 +5,12 @@ const samples = require("../samples.js");
 
 const QuickLinks = React.createClass({
 
+  displayName: "QuickLinks",
+
   propTypes: {
     evaluate: PropTypes.func.isRequired
   },
 
-  displayName: "QuickLinks",
-
   evaluateExpressions(expressions) {
     expressions.forEach(
       expression => this.props.evaluate(expression)
@@ -21,7 +21,7 @@ const QuickLinks = React.createClass({
     return Object.keys(samples)
       .map(label => {
         let expressions = samples[label];
-        let length =  expressions.length;
+        let length = expressions.length;
         return dom.button(
           {
             key: label,
@@ -31,7 +31,7 @@ const QuickLinks = React.createClass({
             onClick: () => this.evaluateExpressions(expressions)
           },
           label
-        )
+        );
       });
   },
 

src/launchpad/components/Result.js

@@ -7,26 +7,26 @@ const Grip = require("../../reps/grip");
 const { getSelectableInInspectorGrips } = require("../../reps/rep-utils");
 
 const Result = React.createClass({
+  displayName: "Result",
+
   propTypes: {
     expression: PropTypes.object.isRequired,
     showResultPacket: PropTypes.func.isRequired,
     hideResultPacket: PropTypes.func.isRequired,
   },
 
-  displayName: "Result",
-
-  copyPacketToClipboard: function(e, packet) {
+  copyPacketToClipboard: function (e, packet) {
     e.stopPropagation();
 
-    var textField = document.createElement('textarea');
+    let textField = document.createElement("textarea");
     textField.innerHTML = JSON.stringify(packet, null, "  ");
     document.body.appendChild(textField);
     textField.select();
-    document.execCommand('copy');
+    document.execCommand("copy");
     textField.remove();
   },
 
-  onHeaderClick: function() {
+  onHeaderClick: function () {
     const {expression} = this.props;
     if (expression.showPacket === true) {
       this.props.hideResultPacket();
@@ -35,13 +35,13 @@ const Result = React.createClass({
     }
   },
 
-  renderRepInAllModes: function({ object }) {
+  renderRepInAllModes: function ({ object }) {
     return Object.keys(MODE).map(modeKey =>
        this.renderRep({ object, modeKey })
      );
   },
 
-  renderRep: function({ object, modeKey }) {
+  renderRep: function ({ object, modeKey }) {
     return dom.div(
       {
         className: `rep-element ${modeKey}`,
@@ -63,16 +63,16 @@ const Result = React.createClass({
     );
   },
 
-  renderPacket: function(expression) {
+  renderPacket: function (expression) {
     let {packet, showPacket} = expression;
     let headerClassName = showPacket ? "packet-expanded" : "packet-collapsed";
     let headerLabel = showPacket ? "Hide expression packet" : "Show expression packet";
 
     return dom.div({ className: "packet" },
       dom.header({
-          className: headerClassName,
-          onClick: this.onHeaderClick,
-        },
+        className: headerClassName,
+        onClick: this.onHeaderClick,
+      },
         headerLabel,
         showPacket && dom.button({
           className: "copy-packet-button",
@@ -81,15 +81,14 @@ const Result = React.createClass({
       ),
       showPacket &&
         dom.div({className: "packet-rep"}, Rep({object: packet}))
-    )
+      );
   },
 
-  render: function() {
+  render: function () {
     let {expression} = this.props;
     let {input, packet} = expression;
-    return dom.div({
-        className: "rep-row"
-      },
+    return dom.div(
+      { className: "rep-row" },
       dom.div({ className: "rep-input" }, input),
       dom.div({ className: "reps" }, this.renderRepInAllModes({
         object: packet.exception || packet.result

src/launchpad/components/ResultsList.js

@@ -5,15 +5,15 @@ const ImPropTypes = require("react-immutable-proptypes");
 const Result = createFactory(require("./Result"));
 
 const ResultsList = React.createClass({
+  displayName: "ResultsList",
+
   propTypes: {
     expressions: ImPropTypes.map.isRequired,
     showResultPacket: PropTypes.func.isRequired,
     hideResultPacket: PropTypes.func.isRequired,
   },
 
-  displayName: "ResultsList",
-
-  render: function() {
+  render: function () {
     let {
       expressions,
       showResultPacket,

src/launchpad/reducers/expressions.js

@@ -6,7 +6,9 @@ try {
   storedExpressions = JSON.parse(
     window.localStorage.getItem(constants.LS_EXPRESSIONS_KEY)
   );
-} catch (e) {}
+} catch (e) {
+  // Ignore.
+}
 
 const initialState = storedExpressions
   ? Immutable.fromJS(storedExpressions)
@@ -19,7 +21,7 @@ function update(state = initialState, action) {
     case constants.ADD_EXPRESSION:
       let newState = state.set(key, Immutable.Map(value));
       window.localStorage.setItem(
-        constants.LS_EXPRESSIONS_KEY, 
+        constants.LS_EXPRESSIONS_KEY,
         JSON.stringify(newState.toJS())
       );
       return newState;

src/launchpad/reducers/input.js

@@ -49,7 +49,7 @@ function update(state = initialState, action) {
       return state.withMutations(map => {
         map
           .set("currentValue", history.get(newNavigationKey) || fallbackValue)
-          .set("currentNavigationKey", newNavigationKey|| fallbackNavigationKey);
+          .set("currentNavigationKey", newNavigationKey || fallbackNavigationKey);
       });
   }
 

src/launchpad/selectors/index.js

@@ -10,9 +10,7 @@ function getCurrentInputValue(state) {
   return getInputState(state).get("currentValue");
 }
 
-
-
 module.exports = {
   getCurrentInputValue,
   getExpressions,
-};
+};

src/launchpad/utils/redux/middleware/promise.js

@@ -17,7 +17,6 @@ function seqIdGen() {
 
 function promiseMiddleware({ dispatch, getState }) {
   return next => action => {
-
     if (!action || !Object.keys(action).includes(PROMISE)) {
       return next(action);
     }

src/launchpad/utils/redux/middleware/thunk.js

@@ -16,4 +16,4 @@ function thunk(makeArgs) {
     };
   };
 }
-exports.thunk = thunk;
+exports.thunk = thunk;

src/launchpad/utils/utils.js

@@ -45,7 +45,6 @@ function filterByKey(obj, predicate) {
     }, {});
 }
 
-let keyCounter = 0;
 function generateKey() {
   return `${performance.now()}`;
 }

src/test/mochitest/head.js

@@ -1,8 +1,17 @@
 /* This Source Code Form is subject to the terms of the Mozilla Public
  * License, v. 2.0. If a copy of the MPL was not distributed with this
  * file, You can obtain one at http://mozilla.org/MPL/2.0/. */
-/* eslint no-unused-vars: [2, {"vars": "local"}] */
 
+/* Entirely disable no-unused-vars, because the second line here
+   doesn't seem to work with eslint 3.15.0 -- it doesn't suppress
+   other no-unused-vars errors.  */
+/* eslint-disable no-unused-vars */
+/* eslint no-unused-vars: ["error", {"vars": "local"}] */
+
+/* globals is */
+
+/* Not really a module.  */
+/* eslint-disable strict */
 "use strict";
 
 var { classes: Cc, interfaces: Ci, utils: Cu, results: Cr } = Components;