Skip to content
This repository has been archived by the owner on Sep 21, 2021. It is now read-only.

Release 0.12.4 #789

Conversation

juliandescottes
Copy link
Member

This is just a cherry pick of bc7bb95 on top of reps v0.12.3.

It would solve firefox-devtools/debugger#4639 which would really be nice to get in before 58 ships IMO.

nchevobbe and others added 2 commits November 9, 2017 13:16
This boolean prop prevents the creation of the href attribute on
generated links in the String rep. It is true by default so
consumer can use the String rep safely. We still want to be
able to generate the href attribute (for the JSON panel for example),
this is why we offer the choice to still create it.

Tests are added to make sure we don't regress.
@juliandescottes
Copy link
Member Author

Not sure how this should be merged though.

@nchevobbe
Copy link
Member

Thanks for doing this @juliandescottes .
Not sure what we should do with that too

@juliandescottes
Copy link
Member Author

Thanks for having a look, I guess we need to branch from 0.12.3 ?

@nchevobbe
Copy link
Member

yes, it sounds good

@juliandescottes
Copy link
Member Author

Let's wait to see if @jasonLaster is ok with the approach for the debugger then. After all that's the only reason why this version is needed.

@juliandescottes juliandescottes changed the base branch from master to branch-v0.12.3 November 9, 2017 13:24
@jasonLaster
Copy link
Contributor

ooh. I like this idea, it takes the pressure off the reduxification effort. I think we can do this as long as we merge into a 12x branch. and then NPM publish.

Thanks @juliandescottes

@juliandescottes
Copy link
Member Author

Cool! I created the branch, should be ready to merge and publish.

@juliandescottes juliandescottes merged commit e025070 into firefox-devtools:branch-v0.12.3 Nov 9, 2017
@nchevobbe
Copy link
Member

great, thanks a lot @juliandescottes !
I'll think of doing this in the future if a similar thing happens

@juliandescottes juliandescottes deleted the release-0.12.4 branch November 9, 2017 15:13
@juliandescottes
Copy link
Member Author

You're welcome :) Thanks for carefully tagging all the releases so far, would have been a nightmare without this.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants