-
Notifications
You must be signed in to change notification settings - Fork 97
Release 0.12.4 #789
Release 0.12.4 #789
Conversation
This boolean prop prevents the creation of the href attribute on generated links in the String rep. It is true by default so consumer can use the String rep safely. We still want to be able to generate the href attribute (for the JSON panel for example), this is why we offer the choice to still create it. Tests are added to make sure we don't regress.
Not sure how this should be merged though. |
Thanks for doing this @juliandescottes . |
Thanks for having a look, I guess we need to branch from 0.12.3 ? |
yes, it sounds good |
Let's wait to see if @jasonLaster is ok with the approach for the debugger then. After all that's the only reason why this version is needed. |
ooh. I like this idea, it takes the pressure off the reduxification effort. I think we can do this as long as we merge into a 12x branch. and then NPM publish. Thanks @juliandescottes |
Cool! I created the branch, should be ready to merge and publish. |
great, thanks a lot @juliandescottes ! |
You're welcome :) Thanks for carefully tagging all the releases so far, would have been a nightmare without this. |
This is just a cherry pick of bc7bb95 on top of reps v0.12.3.
It would solve firefox-devtools/debugger#4639 which would really be nice to get in before 58 ships IMO.