This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix Console Hang #4653
Merged
Fix Console Hang #4653
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
console-hang
branch
2 times, most recently
from
f049071 to
2428ada
Compare
jasonLaster
force-pushed
the
console-hang
branch
from
2428ada to
e8a16a1
Compare
bomsy
approved these changes
Nov 11, 2017
|
i like! |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #3991
Summary of Changes
This fixes a super long hang (10seconds) when parsing the debugger bundle locally. Generally we should try not to wait for something when it is on the critical path
Test Plan
all mochitests pass