This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Exclude flow types from identifier locations #4590
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
flow-params
branch
3 times, most recently
from
61d50c0 to
fead932
Compare
jasonLaster
force-pushed
the
flow-params
branch
from
fead932 to
85c3c84
Compare
bomsy
approved these changes
Nov 7, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #3462
Summary of Changes
Previously we were using the full identifier location, which included the type annotation range: e.g
name: string. We now update the identifiers end column to just includename.Test Plan
Unit test
Screenshot