This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 758
update 10-17-2017 #4400
Merged
jasonLaster
merged 3 commits into
firefox-devtools:master
from
codehag:updates/10-17-2017
Oct 20, 2017
Merged
update 10-17-2017 #4400
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,134 @@ | ||
## October 17, | ||
28 prs, 15 authors | ||
|
||
### The highlights this week: | ||
|
||
* New Go to line Modal, allowing users to go to a specific line in an open file | ||
* Showing react classes in preview | ||
* Improvements to the source tree panel including | ||
* Setting a root folder | ||
* Collapsing all nodes | ||
* we managed a substantial refactoring of our editor, making it more modular and easy to work with for developers | ||
* new docs were added regarding triaging and merge conflicts | ||
|
||
|
||
Thank you to all of our contributors this week! [@James300], [@pradeepgangwar], [@jasonLaster], [@MFry], [@Fischer-L], [@tromey], [@nyrosmith], [@codehag], [@digitarald], [@jfo], [@9andresc], [@yurydelendik], [@samuel-peers], [@lukaszsobek], and [@khal0988] | ||
|
||
### Modals | ||
We added a new modal and improves the styles of the existing modals. You can now search the file by line, using `:` or the modal, thank you to @jfo for his work on that, and to @9andresc! | ||
|
||
* [add a GotoLineModal][pr-13] - [@jfo] | ||
* [modal height and position changed][pr-16] - [@9andresc] | ||
![gotoline] | ||
|
||
### Framework specific changes | ||
We continued improving our react support, and now use react class names in preview. Thanks to @samuel-peers! | ||
|
||
* [React preview display name][pr-19] - [@samuel-peers] | ||
|
||
![react-preview-display] | ||
|
||
### Sources | ||
|
||
On the source tree, we have introduced setting a root directory, which allows a user to focus on a specific subdirectory in their tree, rather than seeing everything at once. It is also possible to collapse all nodes in the source tree using alt-click. We also made a number of small tweeks to the ui of the primary panel. Thanks to @khal0988, @Fischer-L and @pradeepgangwar. | ||
|
||
* [[SourceTree] Set root directory][pr-25] - [@khal0988] | ||
|
||
![sourcetree-root-dir] | ||
|
||
* [Update sources arrow][pr-12] - [@jasonLaster] | ||
* [Align empty message in Source Tab][pr-1] - [@pradeepgangwar] | ||
* [Make alt click expand/collapse all the nodes][pr-5] - [@Fischer-L] | ||
|
||
![alt-click-collapse-node] | ||
|
||
|
||
### Secondary panes | ||
|
||
We fixed a long standing problem in the secondary panes, where the command bar would be included in the scroll. Thanks to @James300 for that | ||
|
||
* [WIP - Fix Secondary Panes Scroll Bar][pr-0] - [@James300] | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. lets drop the WIP |
||
|
||
![secondary-panes] | ||
|
||
|
||
Docs | ||
* [Improve triaging docs][pr-14] - [@jasonLaster] | ||
* [add docs on merge conflicts][pr-22] - [@jasonLaster] | ||
|
||
Infrastructure | ||
* [(WIP) Improve maintainer experience][pr-9] - [@nyrosmith] | ||
* [travis bump][pr-17] - [@jasonLaster] | ||
* [Update travis MC commit][pr-3] - [@jasonLaster] | ||
* [Remove last vestige of devtools.debugger.client-source-maps-enabled][pr-6] - [@tromey] | ||
* [Release (10-11)][pr-21] - [@jasonLaster] | ||
* [small prettier changes][pr-27] - [@jasonLaster] | ||
|
||
CodeHealth | ||
* [File search reducer][pr-20] - [@codehag] | ||
* [add getDomain test][pr-15] - [@codehag] | ||
* [Simplify Editor LifeCycle][pr-2] - [@jasonLaster] | ||
* [Debugger Release ][pr-7] - [@jasonLaster] | ||
* [Upgrade Launchpad][pr-8] - [@jasonLaster] | ||
* [Replace lodash find with native Array::find. Fixes #4343.][pr-11] - [@digitarald] | ||
* [Removed tabs + button][pr-23] - [@MFry] | ||
|
||
|
||
Bugs | ||
* [fix browser toolbox issues][pr-10] - [@codehag] | ||
* [Fix Empty Lines off by one issue][pr-26] - [@jasonLaster] | ||
* [Fixed issue #4291][pr-4] - [@MFry] | ||
* [Fixes mis-aligned tooltip][pr-24] - [@lukaszsobek] | ||
* [Attempt to address \Debugger.Frame is not live\.][pr-18] - [@yurydelendik] | ||
|
||
[secondary-panes]: http://g.recordit.co/42N2vI78yC.gif | ||
[alt-click-collapse-node]: https://user-images.githubusercontent.com/5627487/31287959-b2194326-aaf5-11e7-8353-b074c9d16b1a.gif | ||
[sourcetree-root-dir]:https://user-images.githubusercontent.com/17691158/31521283-ddeac576-af76-11e7-9ddf-f0e573c5a1a4.png | ||
[react-preview-display]: https://user-images.githubusercontent.com/16711897/31501237-4c7239ea-af2f-11e7-8a30-a8a2a9c1371c.png | ||
[gotoline]: http://g.recordit.co/asPJW23XZB.gif | ||
|
||
|
||
[pr-0]:https://github.com/devtools-html/debugger.html/pull/4275 | ||
[pr-1]:https://github.com/devtools-html/debugger.html/pull/4337 | ||
[pr-2]:https://github.com/devtools-html/debugger.html/pull/4301 | ||
[pr-3]:https://github.com/devtools-html/debugger.html/pull/4335 | ||
[pr-4]:https://github.com/devtools-html/debugger.html/pull/4340 | ||
[pr-5]:https://github.com/devtools-html/debugger.html/pull/4309 | ||
[pr-6]:https://github.com/devtools-html/debugger.html/pull/4339 | ||
[pr-7]:https://github.com/devtools-html/debugger.html/pull/4341 | ||
[pr-8]:https://github.com/devtools-html/debugger.html/pull/4332 | ||
[pr-9]:https://github.com/devtools-html/debugger.html/pull/4352 | ||
[pr-10]:https://github.com/devtools-html/debugger.html/pull/4347 | ||
[pr-11]:https://github.com/devtools-html/debugger.html/pull/4344 | ||
[pr-12]:https://github.com/devtools-html/debugger.html/pull/4351 | ||
[pr-13]:https://github.com/devtools-html/debugger.html/pull/4323 | ||
[pr-14]:https://github.com/devtools-html/debugger.html/pull/4321 | ||
[pr-15]:https://github.com/devtools-html/debugger.html/pull/4356 | ||
[pr-16]:https://github.com/devtools-html/debugger.html/pull/4277 | ||
[pr-17]:https://github.com/devtools-html/debugger.html/pull/4358 | ||
[pr-18]:https://github.com/devtools-html/debugger.html/pull/4360 | ||
[pr-19]:https://github.com/devtools-html/debugger.html/pull/4357 | ||
[pr-20]:https://github.com/devtools-html/debugger.html/pull/4368 | ||
[pr-21]:https://github.com/devtools-html/debugger.html/pull/4359 | ||
[pr-22]:https://github.com/devtools-html/debugger.html/pull/4365 | ||
[pr-23]:https://github.com/devtools-html/debugger.html/pull/4367 | ||
[pr-24]:https://github.com/devtools-html/debugger.html/pull/4370 | ||
[pr-25]:https://github.com/devtools-html/debugger.html/pull/4363 | ||
[pr-26]:https://github.com/devtools-html/debugger.html/pull/4361 | ||
[pr-27]:https://github.com/devtools-html/debugger.html/pull/4364 | ||
[@James300]:http://github.com/James300 | ||
[@pradeepgangwar]:http://github.com/pradeepgangwar | ||
[@jasonLaster]:http://github.com/jasonLaster | ||
[@MFry]:http://github.com/MFry | ||
[@Fischer-L]:http://github.com/Fischer-L | ||
[@tromey]:http://github.com/tromey | ||
[@nyrosmith]:http://github.com/nyrosmith | ||
[@codehag]:http://github.com/codehag | ||
[@digitarald]:http://github.com/digitarald | ||
[@jfo]:http://github.com/jfo | ||
[@9andresc]:http://github.com/9andresc | ||
[@yurydelendik]:http://github.com/yurydelendik | ||
[@samuel-peers]:http://github.com/samuel-peers | ||
[@lukaszsobek]:http://github.com/lukaszsobek | ||
[@khal0988]:http://github.com/khal0988 | ||
|
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets make the header "Go to line" and move the fix Bugs or a UI section