Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Switch Close Button from PropType to Flow Props #4166

Merged
merged 1 commit into from
Sep 26, 2017
Merged

Switch Close Button from PropType to Flow Props #4166

merged 1 commit into from
Sep 26, 2017

Conversation

borisstgermain
Copy link
Contributor

Associated Issue: #2804

Summary of Changes

  • Change shared/Button/Close from PropTypes to Flow Props

Test Plan

Example test plan:

  • yarn run test
  • yarn run flow

codehag
codehag approved these changes Sep 26, 2017
View reviewed changes
Copy link
Contributor

@codehag codehag left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thanks!

@codehag codehag merged commit 823ec4c into firefox-devtools:master Sep 26, 2017
khal0988 pushed a commit to khal0988/debugger.html that referenced this pull request Oct 13, 2017
@borisstgermain
Switch Close Button from PropType to Flow Props (firefox-devtools#4166)
0c98ec6
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@codehag codehag codehag approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@borisstgermain @codehag