This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Switch SearchBar and ChromeScopes Proptypes to flow props #4092
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
reviewed
Sep 19, 2017
| @@ -32,6 +31,12 @@ function createNode(name, path, contents) { | |||
| } | |||
|
|
|||
| class Scopes extends Component { | |||
| props: { | |||
| scopes: Array<Object>, | |||
There was a problem hiding this comment.
I think you can import Scope from flow-types/debugger.html
| scopes: Array<Object>, | ||
| loadedObjects: Map<string, any>, | ||
| loadObjectProperties: Function, | ||
| pauseInfo: Object |
There was a problem hiding this comment.
perhaps the same w/ PauseInfo
| props: { | ||
| scopes: Array<Object>, | ||
| loadedObjects: Map<string, any>, | ||
| loadObjectProperties: Function, |
There was a problem hiding this comment.
lets type the params: (string) => void or something like that
|
@jasonLaster thanks, I've addressed the comments. Would you happen to know if there's any difference between |
nope, none |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hi! first PR, hoping to help :)
Associated Issue: #2804
Summary of Changes
Changed PropTypes to Flow Props
Test Plan