This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Copy function #3970
Merged
Copy function #3970
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
copy-function
branch
2 times, most recently
from
5d8072b
to
d391773
Compare
flodolo
previously requested changes
Sep 11, 2017
assets/panel/debugger.properties
Outdated
| @@ -24,6 +24,11 @@ copySource.accesskey=y | |||
| copySourceUrl=Copy Source Url | |||
| copySourceUrl.accesskey=u | |||
|
|
|||
| # LOCALIZATION NOTE (copyFunctionUrl): This is the text that appears in the | |||
There was a problem hiding this comment.
Again this was not fixed before merging @jasonLaster
assets/panel/debugger.properties
Outdated
| # LOCALIZATION NOTE (copyFunctionUrl): This is the text that appears in the | ||
| # context menu to copy the source URL of file open. | ||
| copyFunction=Copy Function | ||
| copyFunction.accesskey=f |
jasonLaster
force-pushed
the
copy-function
branch
from
d391773
to
9e8ef1d
Compare
Codecov Report
@@ Coverage Diff @@
## master #3970 +/- ##
==========================================
+ Coverage 54.91% 55.03% +0.12%
==========================================
Files 131 132 +1
Lines 5084 5111 +27
Branches 1048 1050 +2
==========================================
+ Hits 2792 2813 +21
- Misses 2292 2298 +6
Continue to review full report at Codecov.
|
|
LGTM! will test! |
bomsy
reviewed
Sep 11, 2017
src/components/Editor/EditorMenu.js
Outdated
| @@ -1,6 +1,7 @@ | |||
| import { showMenu } from "devtools-launchpad"; | |||
| import { isOriginalId } from "devtools-source-map"; | |||
| import { copyToTheClipboard } from "../../utils/clipboard"; | |||
| import { getClosestFunction } from "../../utils/breakpoint"; | |||
There was a problem hiding this comment.
This does not seem to be used
bomsy
reviewed
Sep 11, 2017
src/utils/breakpoint/index.js
Outdated
| export { | ||
| getASTLocation, | ||
| findScopeByName, | ||
| getClosestFunction |
flodolo
suggested changes
Sep 12, 2017
assets/panel/debugger.properties
Outdated
| @@ -24,6 +24,11 @@ copySource.accesskey=y | |||
| copySourceUrl=Copy Source Url | |||
| copySourceUrl.accesskey=u | |||
|
|
|||
| # LOCALIZATION NOTE (copyFunction): This is the text that appears in the | |||
| # context menu to copy the source URL of file open. | |||
assets/panel/debugger.properties
Outdated
| @@ -24,6 +24,11 @@ copySource.accesskey=y | |||
| copySourceUrl=Copy Source Url | |||
| copySourceUrl.accesskey=u | |||
|
|
|||
| # LOCALIZATION NOTE (copyFunction): This is the text that appears in the | |||
| # context menu to copy the source URL of file open. | |||
| copyFunction=Copy Function | |||
|
Small suggestion: "flash" the entire function as a way to signal to the user the function was copied? Some sort of feedback would be awesome. |
|
@darkwing lets do that as a follow up. We have some great flash technology :P |
jasonLaster
force-pushed
the
copy-function
branch
from
87c0e8b
to
3f298c1
Compare
jasonLaster
commented
Sep 13, 2017
| @@ -24,6 +24,11 @@ copySource.accesskey=y | |||
| copySourceUrl=Copy Source URL | |||
| copySourceUrl.accesskey=u | |||
|
|
|||
| # LOCALIZATION NOTE (copyFunction): This is the text that appears in the | |||
| # context menu to copy the function the user selected | |||
| copyFunction.label=Copy Function | |||
There was a problem hiding this comment.
@flodolo sorry, that's embarrassing :/
|
i guess this will need some more love... |
jasonLaster
force-pushed
the
copy-function
branch
from
3f298c1
to
9bd627a
Compare
|
This is good to go IMO. I agree the flash can come later. |
jasonLaster
force-pushed
the
copy-function
branch
from
9bd627a
to
18d3748
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
Small fun feature for copying a function.
Test Plan
unit tests
Screenshots/Videos (OPTIONAL)