-
Notifications
You must be signed in to change notification settings - Fork 759
[Breakpoints] setting a condition should enable a breakpoint #3754
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great to me!
Lets see if the tests pass
There is an eslint issue
(don't worry about the warnings, we will take care of that separately!) |
Codecov Report
@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
+ Coverage 56.14% 56.52% +0.37%
==========================================
Files 118 118
Lines 4679 4639 -40
Branches 965 957 -8
==========================================
- Hits 2627 2622 -5
+ Misses 2052 2017 -35
Continue to review full report at Codecov.
|
Codecov Report
@@ Coverage Diff @@
## master #3754 +/- ##
==========================================
+ Coverage 56.14% 56.52% +0.37%
==========================================
Files 118 118
Lines 4679 4639 -40
Branches 965 957 -8
==========================================
- Hits 2627 2622 -5
+ Misses 2052 2017 -35
Continue to review full report at Codecov.
|
and re-opening so i can re-run CI |
Associated Issue: #3730
Summary of Changes