This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Convert propTypes to Flow Props #2842
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #2842 +/- ##
=======================================
Coverage 58.63% 58.63%
=======================================
Files 63 63
Lines 2367 2367
Branches 487 487
=======================================
Hits 1388 1388
Misses 979 979Continue to review full report at Codecov.
|
jasonLaster
approved these changes
May 7, 2017
src/components/App.js
Outdated
| @@ -37,12 +37,21 @@ const WelcomeBox = createFactory(_WelcomeBox); | |||
| import _EditorTabs from "./Editor/Tabs"; | |||
| const EditorTabs = createFactory(_EditorTabs); | |||
|
|
|||
| type Props = { | |||
| selectSource: Function, | |||
| selectedSource: Object, | |||
There was a problem hiding this comment.
Lets use the Source or SourceRecord type here
There was a problem hiding this comment.
@jasonLaster Ok! :)
|
Thanks @AgtLucas! |
|
@jasonLaster No problem! :) |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Associated Issue: #2804
Summary of Changes
AppandWelcomeBoxto Flow PropsTest Plan
Tell us a little a bit about how you tested your patch.
Example test plan: