This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Fix tabs reselect #2799
Merged
Fix tabs reselect #2799
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
force-pushed
the
fix-tabs-reselect
branch
2 times, most recently
from
bd6c105 to
17b9be8
Compare
jasonLaster
commented
May 3, 2017
| horizontal: boolean, | ||
| startPanelCollapsed: boolean, | ||
| endPanelCollapsed: boolean | ||
| }; |
There was a problem hiding this comment.
switches from proptypes to props
|
|
||
| if (!sourceTab) { | ||
| return; | ||
| } |
There was a problem hiding this comment.
flow doesn't know that we'll have a source in the tab list...
jasonLaster
force-pushed
the
fix-tabs-reselect
branch
from
17b9be8 to
347cba4
Compare
|
Looks Good! |
bomsy
approved these changes
May 3, 2017
DanUgelow
pushed a commit
to DanUgelow/debugger.html
that referenced
this pull request
May 4, 2017
* update tests * type tabs component * fixes * fixes
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes