Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

upgrade to reps 0.1.1 & add Window->Global formatting #2019

Merged
merged 1 commit into from
Feb 14, 2017

Conversation

juliandescottes
Copy link
Member

Associated Issue: firefox-devtools/reps#47

This PR upgrades to reps 0.1.1 and re-adds the Window->Global formatting.
(This is now handled via a displayClass property rather than with a boolean)

Summary of Changes

  • bump reps version from 0.0.8 to 0.1.1
  • use displayClass to customize the Window rep display in Scopes.js

Test Plan

Tell us a little a bit about how you tested your patch.

Example test plan:

  • yarn install,
  • did a simple debug flow
  • checked that Global was displayed

Screenshots/Videos

image

cc @jasonLaster

@codecov-io
Copy link

codecov-io commented Feb 14, 2017

Codecov Report

Merging #2019 into master will not change coverage.
The diff coverage is n/a.

@@          Coverage Diff           @@
##           master   #2019   +/-   ##
======================================
  Coverage       0%      0%           
======================================
  Files          39      39           
  Lines         667     667           
======================================
  Misses        667     667

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f0abfb8...c69165a. Read the comment docs.

@wldcordeiro wldcordeiro merged commit afaef1f into firefox-devtools:master Feb 14, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants