Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

Vertical layout - add firefox support. #1365

Merged
merged 1 commit into from
Dec 1, 2016

Conversation

kdzwinel
Copy link
Contributor

@kdzwinel kdzwinel commented Nov 30, 2016

Associated Issue: #1357

Summary of Changes

  • replaced non-standard way of adding listener to matchMedia object (onchange =) with a standard one (addListener)

Test Plan

  • test in Firefox
  • test in Safari
  • test in Chrome

Screenshots/Videos

working on ff and safari

}
},

componentWillUnmount() {
verticalLayoutBreakpoint.onchange = null;
verticalLayoutBreakpoint.removeListener(this.onLayoutChange);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

React auto-binds all methods to the component, so this will work (tested 👍 ).

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

Copy link
Contributor

@jasonLaster jasonLaster left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

}
},

componentWillUnmount() {
verticalLayoutBreakpoint.onchange = null;
verticalLayoutBreakpoint.removeListener(this.onLayoutChange);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yup

@jasonLaster jasonLaster merged commit c417912 into firefox-devtools:master Dec 1, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants