This repository has been archived by the owner on Jan 11, 2023. It is now read-only.
Make sourcemapped location resolve forward instead of back (fixes #1252) #1349
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jasonLaster
approved these changes
Nov 29, 2016
|
I've been trying to test this change against http://wbamberg.github.io/example-websites/source-mapping/index.html but I'm not seeing the source mapped files anymore. I'll look more into it and file another issue. |
This was referenced Jan 4, 2017
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem with sourcemapped breakpoints was that it was searching backwards to find the nearest generated location, which means if there is no mapping for column 0 is would move to the previous line. It's important that we resolve forwards, so it will find the first mapping on the same line (which is a common occurrence, to only map the first piece of code on the line that's indented).