Refactor Sources #114
Refactor Sources #114
Conversation
|
Nice -> Tests doing what they're supposed to do: |
| return Object.assign({}, source, { pathname, filename }); | ||
| } | ||
|
|
||
| function getPathnameFromUrl(sourceUrl) { | ||
| if (!sourceUrl) { | ||
| return ""; | ||
| } | ||
|
|
||
| const url = new URL(sourceUrl); |
There was a problem hiding this comment.
I'm convinced now that that should live somewhere else and we should make a selector that extracts the filename from a source. The URL is undefined in node and none of this code should depend on the browser.
There was a problem hiding this comment.
Yea, that makes a lot of sense. We could do a simple feature check if (URL) {} else {}
There was a problem hiding this comment.
If it's a selector and used from a component, I think it's ok to use URL and assume it's a browser environment. We don't test components in node, we'll run them in the browser, from what I understand
There was a problem hiding this comment.
We don't test components in node, we'll run them in the browser
Yea, we can decide to do that. Lets wait and see though, it might be simpler or significantly faster to run in node. Not sure yet.
selectors
I'll move it over now
jasonLaster
force-pushed
the
sources3
branch
2 times, most recently
from
c9d47b3
to
760f083
Compare
+ add _updateText formatting function for sources + cleanup sources component
|
+1 mergable! |
Started working on Call Stacks and saw an opportunity to cleanup Sources. Nothing scary here.