adding examples #4

ibadia · 2023-09-12T11:24:10Z

No description provided.

yasir7ca · 2023-09-12T11:59:59Z

examples/9.create_cancellation_signature.ts

+import {
+  ORDER_STATUS,
+  ORDER_SIDE,
+  // MinifiedCandleStick,


Suggested change

// MinifiedCandleStick,

yasir7ca · 2023-09-12T12:00:49Z

examples/9.create_cancellation_signature.ts

+    true,
+    Networks.TESTNET_SUI,
+    dummyAccountKey,
+    "ED25519"


Suggested change

"ED25519"

"ED25519" // valid values ED25519 and Secp256k1

yasir7ca · 2023-09-12T12:02:18Z

examples/9.create_cancellation_signature.ts

@@ -0,0 +1,50 @@
+/**


This whole example is redundant, already covered in post_cancel_order.ts so can be deleted

yasir7ca · 2023-09-12T12:02:29Z

examples/8.post_order.ts

+import {
+  ORDER_STATUS,
+  ORDER_SIDE,
+  // MinifiedCandleStick,


Suggested change

// MinifiedCandleStick,

examples/8.post_order.ts

yasir7ca · 2023-09-12T12:05:16Z

examples/7.create_signed_order.ts

+  console.log("Signed Order Created:", signedOrder);
+}
+
+main().then().catch(console.warn);


Suggested change

main().then().catch(console.warn);

main().then().catch(console.error);

yasir7ca · 2023-09-12T12:06:36Z

examples/2.usdc_balance.ts

@@ -0,0 +1,23 @@
+/**


I do not think we need to put any example for showing user how to query your usdc balance from usdc contract

yasir7ca · 2023-09-12T12:07:27Z

examples/4.mint_usdc.ts

@@ -0,0 +1,29 @@
+/**


Users wont be able to mint usdc on our contracts anyways, so example should be removed

yasir7ca · 2023-09-12T12:08:09Z

examples/17.initialise_readonly.ts

@@ -0,0 +1,25 @@
+/**


Please merge this example with 1.initialisation example
in that show both ways of creating a client i.e. write mode and read mode

yasir7ca · 2023-09-12T12:09:33Z

examples/18.get_user_orders.ts

@@ -0,0 +1,37 @@
+/**
+ * Gets user open position on provided(all) markets


Suggested change

* Gets user open position on provided(all) markets

* Query user orders

yasir7ca · 2023-09-12T12:09:41Z

examples/18.get_user_orders.ts

+import {
+  ORDER_STATUS,
+  ORDER_SIDE,
+  // MinifiedCandleStick,


Suggested change

// MinifiedCandleStick,

yasir7ca · 2023-09-12T12:09:56Z

examples/18.get_user_orders.ts

+  );
+}
+
+main().then().catch(console.warn);


Suggested change

main().then().catch(console.warn);

main().then().catch(console.error);

yasir7ca · 2023-09-12T12:10:27Z

examples/5.deposit_to_margin_bank.ts

+  await client.init();
+  console.log(await client.getPublicAddress());
+
+  // deposits 10 USDC to margin bank, uses default USDC/MarginBank Contracts


Suggested change

// deposits 10 USDC to margin bank, uses default USDC/MarginBank Contracts

// deposits 1000 USDC to Bluefin margin bank

yasir7ca · 2023-09-12T12:11:29Z

examples/5.deposit_to_margin_bank.ts

@@ -0,0 +1,31 @@
+/**


I think these three examples can be merged into one

deposit usdc to margin bank

query usdc balance from margin bank

withdraw usdc from margin bank

yasir7ca · 2023-09-12T12:11:42Z

examples/16.adjust_margin.ts

@@ -0,0 +1,44 @@
+/**


Comment out of place

yasir7ca · 2023-09-12T12:11:49Z

examples/16.adjust_margin.ts

+import {
+  ORDER_STATUS,
+  ORDER_SIDE,
+  // MinifiedCandleStick,


Suggested change

// MinifiedCandleStick,

yasir7ca · 2023-09-12T12:13:04Z

examples/16.adjust_margin.ts

+  ); //passing isTermAccepted = true for compliance and authorizarion
+  await client.init();
+  // ADD margin - will add 10 margin to ETH-PERP position
+  console.log(


This example wont work, to adjust margin we have to have an open position. Either we mention in the comment that user has open position then can run the add/remove margin as follows

examples/15.get_contract_addresses.ts

examples/14.get_symbols.ts

yasir7ca · 2023-09-12T12:14:56Z

examples/12.cancel_all_open_orders.ts

+    "ED25519"
+  ); //passing isTermAccepted = true for compliance and authorizarion
+  await client.init();
+  let symbol = "ETH-PERP";


For the purpose of example use different markets for both orders. Place on order on ETH-PERP and other on BTC-PERP

yasir7ca · 2023-09-12T12:15:29Z

examples/11.post_cancel_order.ts

+    leverage: 3,
+  });
+
+  // posts order for cancellation on exchange


Suggested change

// posts order for cancellation on exchange

// cancel order by posted order hash

yasir7ca · 2023-09-12T12:15:41Z

examples/11.post_cancel_order.ts

+  console.log(cancellationResponse.data);
+}
+
+main().then().catch(console.warn);


Suggested change

main().then().catch(console.warn);

main().then().catch(console.error);

examples/11.post_cancel_order.ts

Co-authored-by: Yasir Ejaz <[email protected]>

…-v2-client-ts into examples

yasir7ca · 2023-09-12T13:06:31Z

examples/2.get_margin_bank_balance.ts

+  ); //passing isTermAccepted = true for compliance and authorizarion
+  await client.init();
+
+  // will use margin bank contract from contractAddresses (initialized above)


Suggested change

// will use margin bank contract from contractAddresses (initialized above)

yasir7ca · 2023-09-12T13:06:46Z

examples/2.get_margin_bank_balance.ts

+  );
+}
+
+main().then().catch(console.warn);


Suggested change

main().then().catch(console.warn);

main().then().catch(console.error);

yasir7ca · 2023-09-12T13:08:03Z

examples/3.deposit_and_withdraw_from_margin_bank.ts

+    "USDC Deposited to MarginBank: ",
+    await client.depositToMarginBank(10)
+  );
+  console.log(


Please add a get call in between deposit and withdraw to query margin bank balance

adding examples

88f80eb

ibadia requested a review from a team September 12, 2023 11:24

ibadia added 2 commits September 12, 2023 16:26

linting

c982e6f

adding sockets

66072a1

yasir7ca reviewed Sep 12, 2023

View reviewed changes

examples/16.adjust_margin.ts Outdated

@@ -0,0 +1,44 @@

/**

Copy link

Contributor

yasir7ca Sep 12, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment out of place

yasir7ca reviewed Sep 12, 2023

View reviewed changes

examples/15.get_contract_addresses.ts Outdated Show resolved Hide resolved

yasir7ca reviewed Sep 12, 2023

View reviewed changes

examples/14.get_symbols.ts Outdated Show resolved Hide resolved

yasir7ca reviewed Sep 12, 2023

View reviewed changes

examples/11.post_cancel_order.ts Outdated Show resolved Hide resolved

yasir7ca reviewed Sep 12, 2023

View reviewed changes

examples/11.post_cancel_order.ts Outdated Show resolved Hide resolved

ibadia and others added 5 commits September 12, 2023 17:22

removing redundant

b1cdf9b

Update examples/11.post_cancel_order.ts

895875a

Co-authored-by: Yasir Ejaz <[email protected]>

removing files

67ac96c

Merge branch 'examples' of https://github.com/fireflyprotocol/bluefin…

0ab6857

…-v2-client-ts into examples

fixing numbers

31c25d0

yasir7ca reviewed Sep 12, 2023

View reviewed changes

ibadia added 2 commits September 12, 2023 18:14

fixing build

54061a2

linting

efdbbf0

yasir7ca approved these changes Sep 12, 2023

View reviewed changes

ibadia merged commit 413e085 into main Sep 12, 2023
3 checks passed

ibadia deleted the examples branch September 12, 2023 13:27

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

adding examples #4

adding examples #4

ibadia commented Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023 •

edited

Loading

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

yasir7ca Sep 12, 2023

	main().then().catch(console.warn);
	main().then().catch(console.error);

		@@ -0,0 +1,37 @@
		/**
		* Gets user open position on provided(all) markets

	* Gets user open position on provided(all) markets
	* Query user orders

	// deposits 10 USDC to margin bank, uses default USDC/MarginBank Contracts
	// deposits 1000 USDC to Bluefin margin bank

	// posts order for cancellation on exchange
	// cancel order by posted order hash

adding examples #4

adding examples #4

Conversation

ibadia commented Sep 12, 2023

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yasir7ca Sep 12, 2023 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

yasir7ca Sep 12, 2023 •

edited

Loading