-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
introduce MixedMesh #309
Draft
ksagiyam
wants to merge
3
commits into
master
Choose a base branch
from
ksagiyam/introduce_mixed_map
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
introduce MixedMesh #309
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wence-
reviewed
Mar 27, 2024
gem/gem.py
Outdated
if isinstance(idx, VariableIndex): | ||
v, = extract_variables((idx.expression, )) | ||
variables.add(v) | ||
return tuple(variables) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
sets are not ordered. Is that a problem?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No. Fixed.
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
April 17, 2024 11:33
ddc1759
to
5b66b45
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
May 2, 2024 23:13
8a0bcc6
to
de997e8
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
June 10, 2024 21:49
de997e8
to
36adb9e
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
June 26, 2024 19:24
36adb9e
to
64bc2df
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
July 12, 2024 09:48
64bc2df
to
fc8289e
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
July 25, 2024 18:35
fc8289e
to
9be8132
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
August 20, 2024 16:55
9be8132
to
3a8e49a
Compare
ksagiyam
force-pushed
the
ksagiyam/introduce_mixed_map
branch
from
August 20, 2024 18:36
f3a646c
to
c4ed54a
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce
MixedMesh
class in UFL to handle submesh problems.Depend on:
UFL (require rebasing)