Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure compile_ufl output has correct free indices #237

Closed
wants to merge 2 commits into from
Closed

Ensure compile_ufl output has correct free indices #237

wants to merge 2 commits into from

Commits on Feb 4, 2021

  1. Make delta always correct expression 

    This removes a shortcut in delta which would return gem.Literal(1.) for
Delta(j, j). This shortcut stopped IndexSum(Delta(i, i), i) doing the
right thing since it stopped i from being a free index of the expression
produced by Delta.

Deltas with repeated indices are now replaced with gem.Literal(1.) by
gem.optimise.replace_indices_delta.
    @ReubenHill
    ReubenHill committed Feb 4, 2021
    Configuration menu
    Copy the full SHA
    6cdeb3c View commit details
    Browse the repository at this point in the history

Commits on Feb 5, 2021

  1. Ensure compile_ufl output has correct free indices 

    When an expression given to compile_ufl does not have points in the
input PointSet in its expression tree, the resulting gem expression has
missing free indices. This fixes that.
    @ReubenHill
    ReubenHill committed Feb 5, 2021
    Configuration menu
    Copy the full SHA
    d711e72 View commit details
    Browse the repository at this point in the history