Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle variants for RT and Nedelec spaces #217

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Handle variants for RT and Nedelec spaces #217

merged 1 commit into from
Jul 21, 2020

Conversation

wence-
Copy link
Contributor

@wence- wence- commented Jun 10, 2020

Allows switching between point component and integral moment face/edge nodes.

wence-
wence- commented Jun 10, 2020
View reviewed changes
Copy link
Contributor Author

@wence- wence- left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor cleanups and one question.

tsfc/fiatinterface.py Outdated Show resolved Hide resolved
tsfc/finatinterface.py Outdated Show resolved Hide resolved
@wence- wence- mentioned this pull request Jun 10, 2020
Merged
@wence-
Copy link
Contributor Author

wence- commented Jun 10, 2020

Needs FInAT/FInAT#56 and FEniCS/fiat#52.

@wence- wence- force-pushed the fabianL/feature/interpolation-nodes branch from d7e4f19 to 6e8c352 Compare July 14, 2020 11:19
miklos1
miklos1 previously approved these changes Jul 14, 2020
View reviewed changes
Copy link
Member

@miklos1 miklos1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Much better now.

@wence- wence- force-pushed the fabianL/feature/interpolation-nodes branch from 6e8c352 to 0ade850 Compare July 21, 2020 11:22
@wence- wence- merged commit c3922a5 into master Jul 21, 2020
@wence- wence- deleted the fabianL/feature/interpolation-nodes branch July 21, 2020 11:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@miklos1 miklos1 miklos1 left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@wence- @miklos1 @FabianL1908