Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

FML #3041

Merged
merged 12 commits into from
Oct 25, 2023
Merged

FML #3041

merged 12 commits into from
Oct 25, 2023

Conversation

JDBetteridge
Copy link
Member

FML

dham
dham previously requested changes Jul 26, 2023
View reviewed changes
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
@JDBetteridge JDBetteridge marked this pull request as ready for review September 22, 2023 18:00
@JDBetteridge JDBetteridge requested a review from dham September 25, 2023 13:21
tommbendall
tommbendall previously requested changes Sep 25, 2023
View reviewed changes
Copy link
Contributor

@tommbendall tommbendall left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have been thinking that we should rename the label name to name_label, so that we don't add an object called name to Firedrake's namespace, which could end up being very confusing!

firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
@JDBetteridge JDBetteridge dismissed stale reviews from tommbendall and dham October 5, 2023 11:01

stale

dham
dham requested changes Oct 11, 2023
View reviewed changes
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
wence-
wence- reviewed Oct 12, 2023
View reviewed changes
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
firedrake/fml/replacement.py Outdated Show resolved Hide resolved
firedrake/fml/replacement.py Outdated Show resolved Hide resolved
firedrake/fml/replacement.py Outdated Show resolved Hide resolved
@JDBetteridge
Copy link
Member Author

For those with opinions, feel free to review new docstrings and typehints policy.

dham
dham requested changes Oct 25, 2023
View reviewed changes
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
firedrake/fml/form_manipulation_language.py Outdated Show resolved Hide resolved
@dham dham merged commit 47687fc into master Oct 25, 2023
7 of 8 checks passed
@dham dham deleted the JDBetteridge/fml branch October 25, 2023 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@connorjward connorjward connorjward left review comments

@ReubenHill ReubenHill ReubenHill left review comments

@stephankramer stephankramer stephankramer left review comments

@wence- wence- wence- left review comments

@dham dham dham approved these changes

@tommbendall tommbendall tommbendall left review comments

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@JDBetteridge @dham @wence- @stephankramer @ReubenHill @tommbendall @connorjward