Ksagiyam/periodic extrusion #2582
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
7 times, most recently
from
e3be13d
to
24663c0
Compare
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
7 times, most recently
from
f132f82
to
41108b1
Compare
JDBetteridge
requested changes
Oct 26, 2022
.github/workflows/build.yml
Outdated
| @@ -42,7 +42,7 @@ jobs: | |||
| - name: Build Firedrake | |||
| run: | | |||
| cd .. | |||
| ./firedrake/scripts/firedrake-install $COMPLEX --venv-name build --tinyasm --disable-ssh --minimal-petsc --slepc --documentation-dependencies --install thetis --install gusto --install icepack --install irksome --install femlium --no-package-manager|| (cat firedrake-install.log && /bin/false) | |||
| ./firedrake/scripts/firedrake-install $COMPLEX --venv-name build --tinyasm --disable-ssh --minimal-petsc --slepc --documentation-dependencies --install thetis --install gusto --install icepack --install irksome --install femlium --no-package-manager --package-branch firedrake ksagiyam/periodic_extrusion --package-branch pyop2 ksagiyam/periodic_extrusion|| (cat firedrake-install.log && /bin/false) | |||
|
|
||
|
|
||
| @pytest.mark.parallel(nprocs=3) | ||
| def test_extruded_periodic_annulus(): |
There was a problem hiding this comment.
Could do the same for a torus mesh
There was a problem hiding this comment.
Added a comment in ExtrudedMesh doc.
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
from
41108b1
to
2b26981
Compare
connorjward
requested changes
Dec 7, 2022
firedrake/mesh.py
Outdated
| @@ -2046,7 +2055,7 @@ def Mesh(meshfile, **kwargs): | |||
|
|
|||
|
|
|||
| @PETSc.Log.EventDecorator("CreateExtMesh") | |||
| def ExtrudedMesh(mesh, layers, layer_height=None, extrusion_type='uniform', kernel=None, gdim=None, name=None): | |||
| def ExtrudedMesh(mesh, layers, layer_height=None, extrusion_type='uniform', periodic=False, kernel=None, gdim=None, name=None): | |||
There was a problem hiding this comment.
Would be useful to have TorusMesh and AnnulusMesh functions in utility_meshes.py.
There was a problem hiding this comment.
Added AnnulusMesh and SolidTorusMesh.
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
7 times, most recently
from
8af256a
to
d07959e
Compare
dham
requested changes
Feb 22, 2023
firedrake/utility_meshes.py
Outdated
| distribution_name=None, | ||
| permutation_name=None, | ||
| ): | ||
| """Generate a solid toroidal mesh (with axis z) periodically extruding a disk mesh |
| r, | ||
| nr=4, | ||
| nt=32, | ||
| distribution_parameters=None, |
firedrake/utility_meshes.py
Outdated
|
|
||
| :arg R: The major radius | ||
| :arg r: The minor radius | ||
| :kwarg nR: (optional), number of cells in the major direction (min 3, defaults to 8) |
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
3 times, most recently
from
b4c971c
to
5fa9e65
Compare
ksagiyam
force-pushed
the
ksagiyam/periodic_extrusion
branch
from
5fa9e65
to
a8c1c7a
Compare
dham
reviewed
Mar 8, 2023
| COMM_WORLD). | ||
| :kwarg radius: (optional) radius of the circle to approximate. | ||
| :kwarg degree: polynomial degree of coordinate space (e.g., | ||
| cells are straight line segments if degree=1). |
dham
approved these changes
Mar 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #2570
Enable periodic extrusion.
Need to do more testing,Done.Need to fix I/O for this new mesh.Done.Depends on: OP2/PyOP2#675(Merged)