Add disk caching for interpolation kernels #2348
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
connorjward
force-pushed
the
connorjward/cache-interpolation-kernels
branch
from
dd15570
to
6fb0bfb
Compare
ReubenHill
reviewed
Feb 17, 2022
ReubenHill
reviewed
Feb 17, 2022
connorjward
force-pushed
the
connorjward/cache-interpolation-kernels
branch
2 times, most recently
from
c94bce5
to
e705836
Compare
wence-
reviewed
Feb 25, 2022
connorjward
force-pushed
the
connorjward/cache-interpolation-kernels
branch
6 times, most recently
from
551ab42
to
54bdd8f
Compare
ReubenHill
reviewed
Mar 31, 2022
This should enable caching of ExpressionKernels since they are no longer 'heavy'.
connorjward
force-pushed
the
connorjward/cache-interpolation-kernels
branch
from
54bdd8f
to
cec68cb
Compare
dham
previously approved these changes
Apr 7, 2022
connorjward
force-pushed
the
connorjward/cache-interpolation-kernels
branch
from
cec68cb
to
3d356da
Compare
|
@sv2518 this needs to go in with firedrakeproject/tsfc#268 |
sv2518
approved these changes
Apr 7, 2022
sv2518
added a commit
that referenced
this pull request
Apr 8, 2022
sv2518
added a commit
that referenced
this pull request
Apr 8, 2022
sv2518
added a commit
that referenced
this pull request
Apr 8, 2022
sv2518
added a commit
that referenced
this pull request
Apr 8, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until now it has not been possible to cache interpolation kernels from TSFC because they stored references to the UFL coefficients (fixed in firedrakeproject/tsfc#268).