Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add PETSc to requirements-git.txt #2065

Merged
merged 3 commits into from
May 11, 2021
Merged

Add PETSc to requirements-git.txt #2065

merged 3 commits into from
May 11, 2021

Conversation

connorjward
Copy link
Contributor

This fixes an install issue where these were removed from PyOP2 in
OP2/PyOP2#617.

@connorjward
Add PETSc to requirements-ext.git
8efa563 
This fixes an install issue where this was removed from PyOP2 in
OP2/PyOP2#617.
@connorjward connorjward force-pushed the connorjward/fix-requirements-file branch from 3959aa0 to 8efa563 Compare May 11, 2021 10:50
@connorjward connorjward changed the title Add PETSc and petsc4py to requirements-ext.git Add PETSc to requirements-git.txt May 11, 2021
@wence-
Copy link
Contributor

wence- commented May 11, 2021

I think that looks right. Does firedrake-install get past the error that one has on master now?

@connorjward
Copy link
Contributor Author

Yes it does

@connorjward
Copy link
Contributor Author

But we might now hit the same issue with petsc4py not being explicitly listed

@connorjward
Copy link
Contributor Author

We are now getting ModuleNotFoundError: No module named 'petsc4py'. Shall I just include the additional line in the requirements-git.txt file even though it's nonsense? I can add an issue so we don't forget to fix this at a later time.

@wence-
Copy link
Contributor

wence- commented May 11, 2021

We are now getting ModuleNotFoundError: No module named 'petsc4py'. Shall I just include the additional line in the requirements-git.txt file even though it's nonsense? I can add an issue so we don't forget to fix this at a later time.

Maybe just before the line that does packages += ["firedrake"] do packages.append("petsc4py") ?

@connorjward
Add petsc4py to packages list
25e19ef
@connorjward
Move petsc4py location in script
3fe1e86 
In order for PyOP2 to install it needs to be installed AFTER petsc4py.
@connorjward connorjward mentioned this pull request May 11, 2021
Closed
@connorjward
Copy link
Contributor Author

This now builds. Can we merge it?

@dham dham merged commit eada709 into master May 11, 2021
@dham dham deleted the connorjward/fix-requirements-file branch May 11, 2021 15:12
connorjward added a commit that referenced this pull request May 12, 2021
@connorjward
Add petsc4py to firedrake-update package list
7ccc052 
This is essentially the same as #2065
but fixes firedrake-update.
@connorjward connorjward mentioned this pull request May 12, 2021
Merged
sv2518 pushed a commit that referenced this pull request May 12, 2021
@connorjward @sv2518
Add petsc4py to firedrake-update package list
554c150 
This is essentially the same as #2065
but fixes firedrake-update.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@connorjward @wence- @dham