-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
WIP: Pytential + volumential as external operators #2028
Closed
benSepanski
wants to merge
20
commits into
firedrakeproject:pointwise-adjoint-operator-layer-potentials
from
benSepanski:pointwise-adjoint-operator-layer-potentials-improve-interface
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, the |
|
I also stopped using an intermediate |
Thanks! I had put that in to prevent multiple -tentials from getting
created, which seemed to forcing us to re-build trees and work around some
UFL stuff, but I'm glad to drop it if you've got a better way.
…On Thu, Apr 15, 2021 at 10:29 AM Ben Sepanski ***@***.***> wrote:
I also stopped using an intermediate Evaluator class, and just implement
the methods in the ExternalOperator directly
—
You are receiving this because you are subscribed to this thread.
Reply to this email directly, view it on GitHub
<#2028 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA4XUL7JARQZJ37TVZTPWY3TI4A4PANCNFSM427WMQWA>
.
|
Seems inactive. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm making a PR here so that we can start unifying the layer potential side of things.
This PR makes two big changes to the current
pointwise-adjoint-layer-potentials
branch.Here's the current directory layout:
potential_evaluation/
__init__.py
the basicPotential
class for developers to implementpotentials.py
the public interface to create potentialspytential.py
pytential
implementation of thePotential
classvolumential.py
thevolumential
implementation of thePotential
class