Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

WIP: Pytential + volumential as external operators #2028

Conversation

benSepanski
Copy link
Contributor

@benSepanski benSepanski commented Apr 15, 2021

I'm making a PR here so that we can start unifying the layer potential side of things.

This PR makes two big changes to the current pointwise-adjoint-layer-potentials branch.

  1. Merge in a lot from master so that we support complex
  2. Avoid duplicated code between volumential/pytential external operators by unifying under an abstract class

Here's the current directory layout:

  • potential_evaluation/
    • __init__.py the basic Potential class for developers to implement
    • potentials.py the public interface to create potentials
    • pytential.py pytential implementation of the Potential class
    • WIP: volumential.py the volumential implementation of the Potential class

@benSepanski
Copy link
Contributor Author

Currently, the test_layer_potentials test is failing because of lack of automatic differentiation support

@benSepanski
Copy link
Contributor Author

volumential.py is still a work in progress, so once we are happy with __init__.py, potentials.py, and pytential.py I will finish the volumential part

@benSepanski
Copy link
Contributor Author

I also stopped using an intermediate Evaluator class, and just implement the methods in the ExternalOperator directly

@rckirby
Copy link
Contributor

rckirby commented Apr 15, 2021 via email

@dham
Copy link
Member

dham commented Feb 20, 2024

Seems inactive.

@dham dham closed this Feb 20, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants