Enable slate tensors with variable-layers extruded mesh #1884
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephankramer
force-pushed
the
skramer/slate-variable-layers
branch
from
fb2d6e3
to
328391e
Compare
sv2518
reviewed
Oct 20, 2020
stephankramer
force-pushed
the
skramer/slate-variable-layers
branch
from
328391e
to
b9a5650
Compare
|
Can you rebase onto trunk again? I think the final false failure is now fixed there. |
stephankramer
force-pushed
the
skramer/slate-variable-layers
branch
from
b9a5650
to
4aa69dc
Compare
|
I merged the (hopeful) test fix. Please rebase on top of master. |
This just removes two asserts that claim slate does not work with variable layers - but this has presumably been fixed in #1715 Adds test for assembly of mass and inverse mass matrix on such mesh.
stephankramer
force-pushed
the
skramer/slate-variable-layers
branch
from
4aa69dc
to
4a4b223
Compare
wence-
approved these changes
Nov 19, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This just removes two asserts that claim slate does not work with
variable layers - but this has presumably been fixed in #1715
Adds test for assembly of mass and inverse mass matrix on such mesh.