FDM solver for the de Rham complex (#2801)

Sparse FDM preconditioner for the de Rham complex * add FDM tests for H(curl) and H(div) * test statically-condensed star-relaxation * deterministic sort keys of point_dicts --------- Co-authored-by: David A. Ham <[email protected]>
firedrakeproject · May 11, 2023 · dd12455 · dd12455
1 parent a015738
commit dd12455
Show file tree

Hide file tree

Showing 12 changed files with 2,565 additions and 972 deletions.
diff --git a/firedrake/matrix_free/operators.py b/firedrake/matrix_free/operators.py
@@ -339,7 +339,6 @@ def view(self, mat, viewer=None):
                            type(self).__name__)
 
     def getInfo(self, mat, info=None):
-        from mpi4py import MPI
         memory = self._x.dat.nbytes + self._y.dat.nbytes
         if hasattr(self, "_xbc"):
             memory += self._xbc.dat.nbytes

diff --git a/firedrake/preconditioners/fdm.py b/firedrake/preconditioners/fdm.py
diff --git a/firedrake/preconditioners/gtmg.py b/firedrake/preconditioners/gtmg.py
@@ -29,7 +29,7 @@ def initialize(self, pc):
         if ctx is None:
             raise ValueError("No context found.")
         if not isinstance(ctx, _SNESContext):
-            raise ValueError("Don't know how to get form from %r", ctx)
+            raise ValueError("Don't know how to get form from %r" % ctx)
 
         prefix = pc.getOptionsPrefix()
         options_prefix = prefix + self._prefix
@@ -41,7 +41,7 @@ def initialize(self, pc):
             if ictx is None:
                 raise ValueError("No context found on matrix")
             if not isinstance(ictx, ImplicitMatrixContext):
-                raise ValueError("Don't know how to get form from %r", ictx)
+                raise ValueError("Don't know how to get form from %r" % ictx)
 
             fine_operator = ictx.a
             fine_bcs = ictx.row_bcs
@@ -70,7 +70,7 @@ def initialize(self, pc):
             fine_petscmat.setTransposeNullSpace(fine_transpose_nullspace)
 
         # Handle the coarse operator
-        coarse_options_prefix = options_prefix + "mg_coarse"
+        coarse_options_prefix = options_prefix + "mg_coarse_"
         coarse_mat_type = opts.getString(coarse_options_prefix + "mat_type",
                                          parameters["default_matrix_type"])
 

diff --git a/firedrake/preconditioners/hiptmair.py b/firedrake/preconditioners/hiptmair.py
@@ -201,7 +201,7 @@ def coarsen(self, pc):
         if G_callback is None:
             interp_petscmat = chop(Interpolator(dminus(test), V, bcs=bcs + coarse_space_bcs).callable().handle)
         else:
-            interp_petscmat = G_callback(V, coarse_space, bcs, coarse_space_bcs)
+            interp_petscmat = G_callback(coarse_space, V, coarse_space_bcs, bcs)
 
         return coarse_operator, coarse_space_bcs, interp_petscmat
 

diff --git a/firedrake/preconditioners/hypre_ads.py b/firedrake/preconditioners/hypre_ads.py
@@ -34,12 +34,12 @@ def initialize(self, obj):
         if G_callback is None:
             G = chop(Interpolator(grad(TestFunction(P1)), NC1).callable().handle)
         else:
-            G = G_callback(NC1, P1)
+            G = G_callback(P1, NC1)
         C_callback = appctx.get("get_curl", None)
         if C_callback is None:
             C = chop(Interpolator(curl(TestFunction(NC1)), V).callable().handle)
         else:
-            C = C_callback(V, NC1)
+            C = C_callback(NC1, V)
 
         pc = PETSc.PC().create(comm=obj.comm)
         pc.incrementTabLevel(1, parent=obj)

diff --git a/firedrake/preconditioners/hypre_ams.py b/firedrake/preconditioners/hypre_ams.py
@@ -54,7 +54,7 @@ def initialize(self, obj):
         if G_callback is None:
             G = chop(Interpolator(grad(TestFunction(P1)), V).callable().handle)
         else:
-            G = G_callback(V, P1)
+            G = G_callback(P1, V)
 
         pc = PETSc.PC().create(comm=obj.comm)
         pc.incrementTabLevel(1, parent=obj)

diff --git a/firedrake/preconditioners/patch.py b/firedrake/preconditioners/patch.py
@@ -748,14 +748,14 @@ def initialize(self, obj):
         if ctx is None:
             raise ValueError("No context found on form")
         if not isinstance(ctx, _SNESContext):
-            raise ValueError("Don't know how to get form from %r", ctx)
+            raise ValueError("Don't know how to get form from %r" % ctx)
 
         if P.getType() == "python":
             ictx = P.getPythonContext()
             if ictx is None:
                 raise ValueError("No context found on matrix")
             if not isinstance(ictx, ImplicitMatrixContext):
-                raise ValueError("Don't know how to get form from %r", ictx)
+                raise ValueError("Don't know how to get form from %r" % ictx)
             J = ictx.a
             bcs = ictx.row_bcs
             if bcs != ictx.col_bcs: