address review comments

tests/macro/test_macro_interp_project.py

@@ -21,6 +21,7 @@ def h1_proj(u, f, bcs=None):
     # compute h1 projection of f into u's function
     # space, store the result in u.
     v = TestFunction(u.function_space())
+
     d = {H2: grad, H1: grad, HCurl: curl, HDiv: div, HDivDiv: div}[u.ufl_element().sobolev_space]
     F = (inner(d(u-f), d(v)) * dx
          + inner(u-f, v) * dx)
@@ -123,53 +124,16 @@ def test_scalar_convergence(hierarchy, dim, el, deg, convrate, op):
                          [(2, 'Alfeld-Sorokina', 2, 2),
                           (3, 'Alfeld-Sorokina', 2, 2),
                           (2, 'Reduced-Arnold-Qin', 2, 1),
-                          (3, 'Guzman-Neilan', 1, 1),
                           (3, 'Christiansen-Hu', 1, 1),
                           (2, 'Bernardi-Raugel', 1, 1),
                           (3, 'Bernardi-Raugel', 1, 1),
                           (2, 'Johnson-Mercier', 1, 1),
                           (3, 'Johnson-Mercier', 1, 1),
+                          (3, 'Guzman-Neilan 1st kind H1', 1, 1),
+                          (3, 'Guzman-Neilan H1(div)', 3, 2),
                           ])
 @pytest.mark.parametrize('op', (proj, h1_proj))
 def test_piola_convergence(hierarchy, dim, el, deg, convrate, op):
     if op == proj:
         convrate += 1
     run_convergence(hierarchy[dim], el, deg, convrate, op)
-
-
-# Test that DirichletBC does not set derivative nodes of supersmooth H1 functions
-def test_supersmooth_bcs(mesh):
-    tdim = mesh.topological_dimension()
-    if tdim == 3:
-        V = FunctionSpace(mesh, "GNH1div", 3)
-    else:
-        V = FunctionSpace(mesh, "Alfeld-Sorokina", 2)
-
-    # check that V in H1
-    assert V.ufl_element().sobolev_space == H1
-
-    # check that V is supersmooth
-    nodes = V.finat_element.fiat_equivalent.dual.nodes
-    deriv_nodes = [i for i, node in enumerate(nodes) if len(node.deriv_dict)]
-    assert len(deriv_nodes) == tdim + 1
-
-    deriv_ids = V.cell_node_list[:, deriv_nodes]
-    u = Function(V)
-
-    CG = FunctionSpace(mesh, "Lagrange", 2)
-    RT = FunctionSpace(mesh, "RT", 1)
-    for sub in [1, (1, 2), "on_boundary"]:
-        bc = DirichletBC(V, 0, sub)
-
-        # check that we have the expected number of bc nodes
-        nnodes = len(bc.nodes)
-        expected = tdim * len(DirichletBC(CG, 0, sub).nodes)
-        if tdim == 3:
-            expected += len(DirichletBC(RT, 0, sub).nodes)
-        assert nnodes == expected
-
-        # check that the bc does not set the derivative nodes
-        u.assign(111)
-        u.dat.data_wo[deriv_ids] = 42
-        bc.zero(u)
-        assert numpy.allclose(u.dat.data_ro[deriv_ids], 42)

tests/macro/test_stokes_macroelements.py

@@ -1,5 +1,6 @@
-from firedrake import *
 import pytest
+import numpy
+from firedrake import *
 
 
 @pytest.fixture(params=("square", "cube"))
@@ -11,7 +12,7 @@ def mesh(request):
         return UnitCubeMesh(n, n, n)
 
 
-@pytest.fixture(params=("SV", "GN", "GN2", "AS"))
+@pytest.fixture(params=("SV", "GN", "GN2", "GNH1div"))
 def space(request, mesh):
     family = request.param
     dim = mesh.topological_dimension()
@@ -21,15 +22,14 @@ def space(request, mesh):
     elif family == "GN2":
         V = FunctionSpace(mesh, "GN2", 1)
         Q = FunctionSpace(mesh, "DG", 0, variant="alfeld")
-    elif family == "AS":
-        if dim == 2:
-            V = FunctionSpace(mesh, "AS", 2)
-        else:
-            V = FunctionSpace(mesh, "GNH1div", dim)
+    elif family == "GNH1div":
+        V = FunctionSpace(mesh, "GNH1div", dim)
         Q = FunctionSpace(mesh, "CG", 1, variant="alfeld")
     elif family == "SV":
         V = VectorFunctionSpace(mesh, "CG", dim, variant="alfeld")
         Q = FunctionSpace(mesh, "DG", dim-1, variant="alfeld")
+    else:
+        raise ValueError("Unexpected family")
     return V * Q
 
 
@@ -44,3 +44,43 @@ def test_stokes_complex(mesh, space):
         p.interpolate(div(u))
         assert norm(div(u) - p) < 1E-10
         u.dat.data_wo[k] = 0
+
+
+# Test that DirichletBC does not set derivative nodes of supersmooth H1 functions
+def test_supersmooth_bcs(mesh):
+    tdim = mesh.topological_dimension()
+    if tdim == 3:
+        V = FunctionSpace(mesh, "GNH1div", 3)
+    else:
+        V = FunctionSpace(mesh, "Alfeld-Sorokina", 2)
+
+    assert V.finat_element.complex.is_macrocell()
+
+    # check that V in H1
+    assert V.ufl_element().sobolev_space == H1
+
+    # check that V is supersmooth
+    nodes = V.finat_element.fiat_equivalent.dual.nodes
+    deriv_nodes = [i for i, node in enumerate(nodes) if len(node.deriv_dict)]
+    assert len(deriv_nodes) == tdim + 1
+
+    deriv_ids = V.cell_node_list[:, deriv_nodes]
+    u = Function(V)
+
+    CG = FunctionSpace(mesh, "Lagrange", 2)
+    RT = FunctionSpace(mesh, "RT", 1)
+    for sub in [1, (1, 2), "on_boundary"]:
+        bc = DirichletBC(V, 0, sub)
+
+        # check that we have the expected number of bc nodes
+        nnodes = len(bc.nodes)
+        expected = tdim * len(DirichletBC(CG, 0, sub).nodes)
+        if tdim == 3:
+            expected += len(DirichletBC(RT, 0, sub).nodes)
+        assert nnodes == expected
+
+        # check that the bc does not set the derivative nodes
+        u.assign(111)
+        u.dat.data_wo[deriv_ids] = 42
+        bc.zero(u)
+        assert numpy.allclose(u.dat.data_ro[deriv_ids], 42)

tests/multigrid/test_p_multigrid.py

@@ -116,7 +116,7 @@ def test_prolong_low_order_to_restricted(tp_mesh, tp_family, variant):
         P = prolongation_matrix_matfree(uc, v).getPythonContext()
         P._prolong()
 
-    assert norm(ui + uf - uc, "L2") < 2E-14
+    assert norm(ui + uf - uc, "L2") < 1E-13
 
 
 @pytest.fixture(params=["triangles", "quadrilaterals"], scope="module")