Update to new marked version #59
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markedjs/marked#312 fix dependencies on third-party `marked`
|
I can confirm the issue exists, and is affecting workshopper-adventure and javascripting (as well as any other workshops) which is really frustrating for newbies trying to run them. This is the exact same fix I did on my codebase and I can confirm it works. |
|
Hold up on merging this PR. I would also suggest not pinning to a specific version otherwise you will be missing security patches. |
|
I agree with @UziTech - this should probably be fixed by marked. Closing this issue for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#58