gossip: add support for prune signed data prefix #3708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jumpsiegel
previously approved these changes
Dec 17, 2024
topointon-jump
force-pushed
the
topointon/gossip-prune-signed-prefix
branch
from
24bcc85 to
da19d56
Compare
jumpsiegel
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds support for verifying prune messages sent with a sign data prefix. Until all nodes in the cluster support this, this prefix is not used. We are adding support to be ready for when messages are signed using this prefix.
Tested against a local cluster, receiving and verifying prune messages with and without the prefix.
See anza-xyz/agave#1472