Test current struct versions are in the VersionMap #14
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...present in the latest version from VersionMap. Signed-off-by: Ioana Chirca <[email protected]>
sandreim
reviewed
Jun 25, 2020
| @@ -44,6 +44,8 @@ pub enum VersionizeError { | |||
| StringLength(usize), | |||
| /// Vector length exceeded. | |||
| VecLength(usize), | |||
| /// VersionMap not updated. | |||
There was a problem hiding this comment.
It would be nice to add some more details and how this error can be fixed.
|
Please also mark changes in changelog. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ioana Chirca [email protected]
Reason for This PR
Test for firecracker-microvm/versionize_derive#5. Needs that change to be merged in order to pass.
Description of Changes
[Author TODO: add description of changes.]License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license.
PR Checklist
[Author TODO: Meet these criteria.][Reviewer TODO: Verify that these criteria are met. Request changes if not]git commit -s).unsafecode is properly documented.CHANGELOG.md.