Update seccompiler to use libseccomp #4926
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ShadowCurse
force-pushed
the
seccomp2
branch
4 times, most recently
from
529218b
to
224fdb4
Compare
- Update Rust to 1.82 version - Add libseccomp needed for updated seccompiler version Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
seccomp2
branch
2 times, most recently
from
a7d7fbb
to
902c344
Compare
With a new Rust version, new Clippy entered our repository. This commit aligns our codebase with guidance provided by new lints. Signed-off-by: Egor Lazarchuk <[email protected]>
libseccomp provides better quality compiler for bpf seccomp programs than our current implementation. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
seccomp2
branch
from
902c344
to
35f6ec0
Compare
Signed-off-by: Egor Lazarchuk <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Replace our custom implementation of a seccompiler with libseccomp.
Reason
libseccomp provides better quality compiler for
bpf seccomp programs than our current implementation.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.