Fix 16K host page support #4916
Open
+81
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4916 +/- ##
==========================================
- Coverage 84.09% 84.05% -0.04%
==========================================
Files 251 251
Lines 28061 28089 +28
==========================================
+ Hits 23597 23610 +13
- Misses 4464 4479 +15
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
2 times, most recently
from
2f523ef
to
a879102
Compare
ShadowCurse
requested review from
bchalios and
roypat
and removed request for
bchalios
ShadowCurse
added
Status: Awaiting review
pb8o
reviewed
Nov 15, 2024
| pub const HOST_PAGE_SIZE: usize = 4096; | ||
| pub static mut HOST_PAGE_SIZE: usize = 4096; | ||
|
|
||
| /// Updates the HOST_PAGE_SIZE global variable to the output of |
There was a problem hiding this comment.
Instead of modifying a global, could we make it a function that returns the pagesize? Or use lazy_static!.
There was a problem hiding this comment.
added a method to return the host page size.
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
from
a879102
to
82a4d30
Compare
kalyazin
reviewed
Nov 15, 2024
| #[derive(Debug)] | ||
| pub struct IovDeque<const L: u16> { | ||
| pub iov: *mut libc::iovec, | ||
| pub bytes: u32, |
There was a problem hiding this comment.
I suppose this should be mentioned in the changelog.
There was a problem hiding this comment.
added a note in the Fixed section
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
5 times, most recently
from
a10e8bb
to
c8f2643
Compare
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
from
3fa7522
to
2472eb4
Compare
Firecracker was assumming page sizes for both host and guest are 4K. But they can differ, so split into 2 values. Signed-off-by: Egor Lazarchuk <[email protected]>
Define global variable with host page size and update it at the very beginning of the main function in Firecracker. This way data types which rely on specific host page size can adapt to it. Signed-off-by: Egor Lazarchuk <[email protected]>
Remove restriction on size and host page size. Signed-off-by: Egor Lazarchuk <[email protected]>
Add note about making `IovDeque` to work with any host page size. Signed-off-by: Egor Lazarchuk <[email protected]>
ShadowCurse
force-pushed
the
net_iov_16K_fix
branch
from
2472eb4
to
9c4e018
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Separate
PAGE_SIZEconstant into 2:GUEST_PAGE_SIZEandHOST_PAGE_SIZE.HOST_PAGE_SIZEhas a default of 4K, but is also queried at runtime to support other page sizes.The only structure which did not work with non default 4K pages is
IovDeque. This PR updates itand removes restrictions on the queue size and on the host page size.
Tested16K pages support on rp5 with 16K page kernel.
Reason
Previously Firecracker was working on hosts with non 4K pages, but with 1.10 version we introduced
IovDequetypewhich assumed the host page size to be 4K.
License Acceptance
By submitting this pull request, I confirm that my contribution is made under
the terms of the Apache 2.0 license. For more information on following Developer
Certificate of Origin and signing off your commits, please check
CONTRIBUTING.md.PR Checklist
tools/devtool checkstyleto verify that the PR passes theautomated style checks.
how they are solving the problem in a clear and encompassing way.
in the PR.
CHANGELOG.md.Runbook for Firecracker API changes.
integration tests.
TODO.rust-vmm.